fix(tables): filter behavior #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A preview environment was automatically created via Qovery. Another comment will be posted when deployments are terminated |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit d72b1b3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
RemiBonnet
added
the
breaking change
bdebon
approved these changes
Nov 21, 2022
| @@ -58,13 +60,13 @@ export function PageVariablesMemo(props: PageVariablesProps) { | |||
| export const PageVariables = React.memo(PageVariablesMemo, (prevProps, nextProps) => { | |||
| // Stringify is necessary to avoid Redux selector behavior and so many value are necessary because updated_at is not | |||
| // updated during an import... Problem from backend. | |||
| const prevProsIds = prevProps.filterData.map((envVariables) => ({ | |||
| const prevProsIds = prevProps.variables.map((envVariables) => ({ | |||
There was a problem hiding this comment.
there is a typo in prevPros
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
<TableRowFilter>)PR Checklist
Global
Store
NX
feature,ui,data,utilsClean Code