Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(error): add info in database error messages #386

Merged
merged 1 commit into from Nov 23, 2022

Conversation

bdebon
Copy link
Contributor

@bdebon bdebon commented Nov 23, 2022

What does this PR do?

> Link to the JIRA ticket

The error message was empty, now it displays what we know.

CleanShot 2022-11-23 at 11 51 02@2x


PR Checklist

Global

  • This PR does not introduce any breaking change
  • This PR introduces breaking change(s) and has been labeled as such
  • I have found someone to review this PR and pinged him

Store

  • This PR introduces new store changes

NX

  • I have run the dep-graph locally and made sure the tree was clean i.e no circular dependencies
  • I have followed the library pattern i.e feature, ui, data, utils

Clean Code

  • I made sure the code is type safe (no any)
  • I have included a feature flag on my feature, if applicable

@evoxmusic
Copy link
Contributor

A preview environment was automatically created via Qovery.
Click on the link below to follow its deployment and use it.
👉 [PR] staging - fix(error): add info in database error messages - 2022-11-23T10:51:43Z

Another comment will be posted when deployments are terminated

@nx-cloud
Copy link

nx-cloud bot commented Nov 23, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit eaf6904. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@bdebon
Copy link
Contributor Author

bdebon commented Nov 23, 2022

I also found a better way to print the message without typing the error with any

@evoxmusic
Copy link
Contributor

Your preview environment has been successfully deployed !
Click on the link below to open your service:
👉 console
👉 storybook

@RemiBonnet RemiBonnet self-requested a review November 23, 2022 15:42
@bdebon bdebon merged commit 1d7db30 into staging Nov 23, 2022
@bdebon bdebon deleted the fix/error-message-FRT-564 branch November 23, 2022 16:52
@bdebon
Copy link
Contributor Author

bdebon commented Nov 24, 2022

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants