Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(text): fix small typos #388

Merged
merged 1 commit into from Nov 23, 2022
Merged

fix(text): fix small typos #388

merged 1 commit into from Nov 23, 2022

Conversation

evoxmusic
Copy link
Contributor

What does this PR do?

I fix small typos from the web ui


PR Checklist

Global

  • This PR does not introduce any breaking change
  • This PR introduces breaking change(s) and has been labeled as such
  • I have found someone to review this PR and pinged him

Store

  • This PR introduces new store changes

NX

  • I have run the dep-graph locally and made sure the tree was clean i.e no circular dependencies
  • I have followed the library pattern i.e feature, ui, data, utils

Clean Code

  • I made sure the code is type safe (no any)
  • I have included a feature flag on my feature, if applicable

@evoxmusic
Copy link
Contributor Author

A preview environment was automatically created via Qovery.
Click on the link below to follow its deployment and use it.
👉 [PR] staging - fix(text): fix small typos - 2022-11-23T15:31:50Z

Another comment will be posted when deployments are terminated

@nx-cloud
Copy link

nx-cloud bot commented Nov 23, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 70e73b5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@codecov-commenter
Copy link

Codecov Report

Merging #388 (70e73b5) into staging (e5f480a) will increase coverage by 11.12%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           staging     #388       +/-   ##
============================================
+ Coverage    53.04%   64.16%   +11.12%     
============================================
  Files          295      129      -166     
  Lines         5524     2291     -3233     
  Branches      1183      628      -555     
============================================
- Hits          2930     1470     -1460     
+ Misses        2201      589     -1612     
+ Partials       393      232      -161     
Impacted Files Coverage Δ
...se-create-general/page-database-create-general.tsx 88.23% <ø> (ø)
...organization-general/page-organization-general.tsx 100.00% <ø> (ø)
...bers-feature/page-organization-members-feature.tsx 61.40% <0.00%> (-0.67%) ⬇️
...age-organization-members/row-member/row-member.tsx 69.04% <0.00%> (ø)
...onment-variable/table-row-environment-variable.tsx 42.85% <0.00%> (ø)
...feature/table-row-environment-variable-feature.tsx 45.65% <0.00%> (ø)
...src/lib/ui/layout-onboarding/layout-onboarding.tsx
...-detect-click-outside/use-detect-click-outside.tsx
.../organization/src/lib/slices/organization.slice.ts
...omains/database/src/lib/slices/database.actions.ts
... and 173 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@RemiBonnet
Copy link
Member

Thanks @evoxmusic 🙏

@RemiBonnet RemiBonnet merged commit 60038bd into staging Nov 23, 2022
@RemiBonnet RemiBonnet deleted the fix/small_typos branch November 23, 2022 15:41
@evoxmusic
Copy link
Contributor Author

Your preview environment has been successfully deployed !
Click on the link below to open your service:
👉 console
👉 storybook

@bdebon
Copy link
Contributor

bdebon commented Nov 24, 2022

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants