Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ports): adding info tooltip and reset the value #390

Merged
merged 2 commits into from Nov 24, 2022
Merged

Conversation

bdebon
Copy link
Contributor

@bdebon bdebon commented Nov 23, 2022

What does this PR do?

> Link to the JIRA ticket

Reset the value when toggle public and adding a tooltip on both places we have a port creation.

image


PR Checklist

Global

  • This PR does not introduce any breaking change
  • This PR introduces breaking change(s) and has been labeled as such
  • I have found someone to review this PR and pinged him

Store

  • This PR introduces new store changes

NX

  • I have run the dep-graph locally and made sure the tree was clean i.e no circular dependencies
  • I have followed the library pattern i.e feature, ui, data, utils

Clean Code

  • I made sure the code is type safe (no any)
  • I have included a feature flag on my feature, if applicable

@evoxmusic
Copy link
Contributor

A preview environment was automatically created via Qovery.
Click on the link below to follow its deployment and use it.
👉 [PR] staging - chore(ports): adding info tooltip and reset the value - 2022-11-23T16:51:16Z

Another comment will be posted when deployments are terminated

@nx-cloud
Copy link

nx-cloud bot commented Nov 23, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3c6b790. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@evoxmusic
Copy link
Contributor

Your preview environment has been successfully deployed !
Click on the link below to open your service:
👉 console
👉 storybook

Copy link
Member

@RemiBonnet RemiBonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @bdebon !! 🎉 , small comments:

  • Can you rename the PRs with a fix or feat prefix? Because it's not a chore improvement
  • I find the container of all creation pages small, is it possible to have the same as settings? I think it would make it better
  • I see several possible improvements for this screen

Capture d’écran 2022-11-24 à 10 22 46

  • The toggle should be "small" and the wording can be the same with the modal Publicly exposed
  • I think you can remove the index for the row you can have only "Application port" and "External port" with lowercase port
  • The tooltip could be on the input "External port" (like modal)

@bdebon bdebon changed the title chore(ports): adding info tooltip and reset the value fix(ports): adding info tooltip and reset the value Nov 24, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #390 (3c6b790) into staging (8dc40d7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           staging     #390   +/-   ##
========================================
  Coverage    53.72%   53.72%           
========================================
  Files          298      298           
  Lines         5552     5565   +13     
  Branches      1178     1182    +4     
========================================
+ Hits          2983     2990    +7     
- Misses        2188     2194    +6     
  Partials       381      381           
Impacted Files Coverage Δ
...b/ui/page-settings-ports/crud-modal/crud-modal.tsx 85.71% <100.00%> (+3.89%) ⬆️
...page-application-create-port/port-row/port-row.tsx 100.00% <100.00%> (ø)
libs/pages/logs/infra/src/lib/ui/row/row.tsx 89.47% <0.00%> (-10.53%) ⬇️
...logs/application/src/lib/page-application-logs.tsx 57.50% <0.00%> (-8.22%) ⬇️
...omains/database/src/lib/slices/database.actions.ts 0.00% <0.00%> (ø)
...ources-feature/page-settings-resources-feature.tsx 76.92% <0.00%> (+5.49%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bdebon bdebon merged commit 183e725 into staging Nov 24, 2022
@bdebon bdebon deleted the chore/port-typo branch November 24, 2022 13:13
@bdebon
Copy link
Contributor Author

bdebon commented Nov 24, 2022

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants