New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ports): adding info tooltip and reset the value #390
Conversation
A preview environment was automatically created via Qovery. Another comment will be posted when deployments are terminated |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 3c6b790. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done @bdebon !! 🎉 , small comments:
- Can you rename the PRs with a fix or feat prefix? Because it's not a chore improvement
- I find the container of all creation pages small, is it possible to have the same as settings? I think it would make it better
- I see several possible improvements for this screen
- The toggle should be "small" and the wording can be the same with the modal
Publicly exposed
- I think you can remove the
index
for the row you can have only "Application port" and "External port" with lowercase port - The tooltip could be on the input "External port" (like modal)
libs/shared/ui/src/lib/components/inputs/input-text/input-text.tsx
Outdated
Show resolved
Hide resolved
...rvices/src/lib/ui/page-application-create/page-application-create-port/port-row/port-row.tsx
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## staging #390 +/- ##
========================================
Coverage 53.72% 53.72%
========================================
Files 298 298
Lines 5552 5565 +13
Branches 1178 1182 +4
========================================
+ Hits 2983 2990 +7
- Misses 2188 2194 +6
Partials 381 381
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
🎉 This PR is included in version 1.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
What does this PR do?
> Link to the JIRA ticket
Reset the value when toggle public and adding a tooltip on both places we have a port creation.
PR Checklist
Global
Store
NX
feature
,ui
,data
,utils
Clean Code