New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jobs): full creation flow #393
Conversation
A preview environment was automatically created via Qovery. Another comment will be posted when deployments are terminated |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 0b49c03. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
fb37663
to
b70df77
Compare
Codecov Report
@@ Coverage Diff @@
## staging #393 +/- ##
===========================================
- Coverage 52.87% 52.61% -0.27%
===========================================
Files 306 326 +20
Lines 5730 6206 +476
Branches 1213 1350 +137
===========================================
+ Hits 3030 3265 +235
- Misses 2316 2506 +190
- Partials 384 435 +51
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
0d41f8f
to
995e024
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done @bdebon, we'll have to be careful next time to separate your PRs, I'm afraid we'll end up with some bugs that we could have avoided!
And, you have to make your code look like the creation of a Database and Application, there is a lot of difference can you check and harmonized it?
-
We have the same icon between Lifecycle and Cronjob (on the Figma it's different)
-
When we click on this section should be nice to have all the top of the box clickable, not just the checkbox
-
When I click on the settings "Configure Job" the event isn't automatically open (https://www.loom.com/share/30b768e13d6846afb98c93afcb5f02c6)
...lication/src/lib/feature/page-settings-configure-feature/page-settings-configure-feature.tsx
Outdated
Show resolved
Hide resolved
libs/pages/application/src/lib/feature/page-settings-feature/page-settings-feature.tsx
Show resolved
Hide resolved
...ication/src/lib/feature/page-settings-general-feature/page-settings-general-feature.spec.tsx
Outdated
Show resolved
Hide resolved
libs/pages/application/src/lib/ui/page-settings-configure/page-settings-configure.tsx
Outdated
Show resolved
Hide resolved
libs/shared/console-shared/src/lib/job-configure-settings/job-configure-settings.tsx
Outdated
Show resolved
Hide resolved
libs/shared/console-shared/src/lib/job-general-setting/job-general-setting.spec.tsx
Outdated
Show resolved
Hide resolved
libs/shared/console-shared/src/lib/job-general-setting/job-general-setting.tsx
Outdated
Show resolved
Hide resolved
libs/shared/console-shared/src/lib/job-general-setting/job-general-setting.tsx
Outdated
Show resolved
Hide resolved
eb00b7e
to
6c56c93
Compare
🎉 This PR is included in version 1.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
What does this PR do?
> Link to the JIRA ticket
Put description here
PR Checklist
Global
Store
NX
feature
,ui
,data
,utils
Clean Code