Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jobs): full creation flow #393

Merged
merged 31 commits into from Dec 22, 2022
Merged

feat(jobs): full creation flow #393

merged 31 commits into from Dec 22, 2022

Conversation

bdebon
Copy link
Contributor

@bdebon bdebon commented Nov 24, 2022

What does this PR do?

> Link to the JIRA ticket

Put description here

CleanShot 2022-11-24 at 17 58 34


PR Checklist

Global

  • This PR does not introduce any breaking change
  • This PR introduces breaking change(s) and has been labeled as such
  • I have found someone to review this PR and pinged him

Store

  • This PR introduces new store changes

NX

  • I have run the dep-graph locally and made sure the tree was clean i.e no circular dependencies
  • I have followed the library pattern i.e feature, ui, data, utils

Clean Code

  • I made sure the code is type safe (no any)
  • I have included a feature flag on my feature, if applicable

@evoxmusic
Copy link
Contributor

A preview environment was automatically created via Qovery.
Click on the link below to follow its deployment and use it.
👉 [PR] staging - main structure of the whole flow - 2022-11-24T16:59:02Z

Another comment will be posted when deployments are terminated

@nx-cloud
Copy link

nx-cloud bot commented Nov 24, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0b49c03. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@bdebon bdebon marked this pull request as draft November 24, 2022 16:59
@bdebon bdebon changed the title main structure of the whole flow feat(jobs): full creation flow Nov 24, 2022
@evoxmusic
Copy link
Contributor

Your preview environment has been successfully deployed !
Click on the link below to open your service:
👉 console
👉 storybook

@bdebon bdebon force-pushed the feat/job-creation branch 2 times, most recently from fb37663 to b70df77 Compare November 30, 2022 17:41
@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2022

Codecov Report

Merging #393 (0b49c03) into staging (6dc1e88) will decrease coverage by 0.26%.
The diff coverage is 49.14%.

@@             Coverage Diff             @@
##           staging     #393      +/-   ##
===========================================
- Coverage    52.87%   52.61%   -0.27%     
===========================================
  Files          306      326      +20     
  Lines         5730     6206     +476     
  Branches      1213     1350     +137     
===========================================
+ Hits          3030     3265     +235     
- Misses        2316     2506     +190     
- Partials       384      435      +51     
Impacted Files Coverage Δ
...cation/src/lib/mocks/factories/job-factory.mock.ts 0.00% <0.00%> (ø)
...s/application/src/lib/slices/applications.slice.ts 18.22% <0.00%> (-0.50%) ⬇️
...c/lib/slices/secret-environment-variables.slice.ts 22.85% <0.00%> (-0.34%) ⬇️
.../organization/src/lib/slices/organization.slice.ts 19.68% <0.00%> (ø)
...eature/crud-environment-variable-modal-feature.tsx 52.94% <ø> (ø)
...ture/import-environment-variable-modal-feature.tsx 84.84% <ø> (ø)
...onment-variable-modal-feature/utils/form-check.tsx 100.00% <ø> (ø)
...re/page-settings-feature/page-settings-feature.tsx 0.00% <0.00%> (ø)
libs/pages/application/src/lib/router/router.tsx 100.00% <ø> (ø)
...riable-modal/import-environment-variable-modal.tsx 84.21% <ø> (ø)
... and 56 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bdebon bdebon force-pushed the feat/job-creation branch 3 times, most recently from 0d41f8f to 995e024 Compare December 20, 2022 15:34
@bdebon bdebon marked this pull request as ready for review December 20, 2022 17:26
Copy link
Member

@RemiBonnet RemiBonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @bdebon, we'll have to be careful next time to separate your PRs, I'm afraid we'll end up with some bugs that we could have avoided!
And, you have to make your code look like the creation of a Database and Application, there is a lot of difference can you check and harmonized it?

  • We have the same icon between Lifecycle and Cronjob (on the Figma it's different)
    Capture d’écran 2022-12-21 à 10 51 22

  • When we click on this section should be nice to have all the top of the box clickable, not just the checkbox
    Capture d’écran 2022-12-21 à 10 52 44

  • When I click on the settings "Configure Job" the event isn't automatically open (https://www.loom.com/share/30b768e13d6846afb98c93afcb5f02c6)

@bdebon bdebon merged commit 74eb8c6 into staging Dec 22, 2022
@bdebon bdebon deleted the feat/job-creation branch December 22, 2022 11:48
@bdebon
Copy link
Contributor Author

bdebon commented Dec 22, 2022

🎉 This PR is included in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants