Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pages-job): about + deployments + variables + actions and status #401

Merged
merged 4 commits into from Nov 30, 2022

Conversation

RemiBonnet
Copy link
Member

@RemiBonnet RemiBonnet commented Nov 29, 2022

What does this PR do?

  • Add Job deployment page
  • Add Job status request
  • Add Job about section (image information) for Overview
  • Add Job variables
  • Add Job actions

PR Checklist

Global

  • This PR does not introduce any breaking change
  • This PR introduces breaking change(s) and has been labeled as such
  • I have found someone to review this PR and pinged him

Store

  • This PR introduces new store changes

NX

  • I have run the dep-graph locally and made sure the tree was clean i.e no circular dependencies
  • I have followed the library pattern i.e feature, ui, data, utils

Clean Code

  • I made sure the code is type safe (no any)
  • I have included a feature flag on my feature, if applicable

@evoxmusic
Copy link
Contributor

A preview environment was automatically created via Qovery.
Click on the link below to follow its deployment and use it.
👉 [PR] staging - feat(page-job): about + deployments and status - 2022-11-29T14:29:08Z

Another comment will be posted when deployments are terminated

@nx-cloud
Copy link

nx-cloud bot commented Nov 29, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 77b0b27. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@RemiBonnet RemiBonnet marked this pull request as ready for review November 29, 2022 14:29
@evoxmusic
Copy link
Contributor

Your preview environment has been successfully deployed !
Click on the link below to open your service:
👉 console
👉 storybook

@RemiBonnet RemiBonnet changed the title feat(page-job): about + deployments and status feat(page-job): about + deployments + variables and status Nov 29, 2022
@RemiBonnet RemiBonnet changed the title feat(page-job): about + deployments + variables and status feat(pages-job): about + deployments + variables and status Nov 29, 2022
@RemiBonnet RemiBonnet changed the title feat(pages-job): about + deployments + variables and status feat(pages-job): about + deployments + variables + actions and status Nov 29, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #401 (77b0b27) into staging (355bb3e) will decrease coverage by 0.16%.
The diff coverage is 15.62%.

@@             Coverage Diff             @@
##           staging     #401      +/-   ##
===========================================
- Coverage    53.69%   53.52%   -0.17%     
===========================================
  Files          298      298              
  Lines         5554     5579      +25     
  Branches      1178     1189      +11     
===========================================
+ Hits          2982     2986       +4     
- Misses        2189     2207      +18     
- Partials       383      386       +3     
Impacted Files Coverage Δ
.../application/src/lib/slices/application.actions.ts 0.00% <0.00%> (ø)
...ges/application/src/lib/ui/container/container.tsx 39.28% <0.00%> (-3.03%) ⬇️
...plication/src/lib/ui/page-general/page-general.tsx 50.00% <ø> (ø)
...c/lib/ui/table-row-services/table-row-services.tsx 38.46% <0.00%> (ø)
...nt-buttons-actions/environment-buttons-actions.tsx 51.92% <0.00%> (-1.02%) ⬇️
...able/src/lib/slices/environment-variables.slice.ts 57.89% <14.28%> (-2.11%) ⬇️
...on-buttons-actions/application-buttons-actions.tsx 56.36% <33.33%> (-2.13%) ⬇️
...s/application/src/lib/slices/applications.slice.ts 18.72% <40.00%> (+0.20%) ⬆️
libs/pages/logs/infra/src/lib/ui/row/row.tsx 100.00% <0.00%> (+10.52%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@bdebon bdebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VERY GOOD MY DEAR REMI! I SEE ONLY THINGS THAT I LIKE HERE!
The new family of isThing util makes everything so lovely to review!!

@RemiBonnet RemiBonnet merged commit b7cc4db into staging Nov 30, 2022
@RemiBonnet RemiBonnet deleted the feat/page-job-deployments branch November 30, 2022 08:20
@bdebon
Copy link
Contributor

bdebon commented Nov 30, 2022

🎉 This PR is included in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants