Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(buttons-actions): add tooltip #402

Merged
merged 3 commits into from Dec 1, 2022
Merged

feat(buttons-actions): add tooltip #402

merged 3 commits into from Dec 1, 2022

Conversation

RemiBonnet
Copy link
Member

What does this PR do?

  • Add tooltip for buttons actions

Capture d’écran 2022-11-30 à 17 01 21

PR Checklist

Global

  • This PR does not introduce any breaking change
  • This PR introduces breaking change(s) and has been labeled as such
  • I have found someone to review this PR and pinged him

Store

  • This PR introduces new store changes

NX

  • I have run the dep-graph locally and made sure the tree was clean i.e no circular dependencies
  • I have followed the library pattern i.e feature, ui, data, utils

Clean Code

  • I made sure the code is type safe (no any)
  • I have included a feature flag on my feature, if applicable

@evoxmusic
Copy link
Contributor

A preview environment was automatically created via Qovery.
Click on the link below to follow its deployment and use it.
👉 [PR] staging - feat(buttons-actions): add tooltip - 2022-11-30T16:01:55Z

Another comment will be posted when deployments are terminated

@nx-cloud
Copy link

nx-cloud bot commented Nov 30, 2022 •
edited

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b33e7af. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@RemiBonnet RemiBonnet marked this pull request as ready for review November 30, 2022 16:02
@evoxmusic
Copy link
Contributor

Your preview environment has been successfully deployed !
Click on the link below to open your service:
👉 console
👉 storybook

bdebon
bdebon approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@bdebon bdebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little naming changes. What do you think ?

...ponents/buttons/button-icon-action/button-icon-action-element/button-icon-action-element.tsx Outdated
@@ -24,6 +27,20 @@ export function ButtonIconActionElement(props: ButtonIconActionElementProps) {

const [open, setOpen] = useState(false)

const hasTooltip = (content: React.ReactNode, withRightBorder = false) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The naming of this is a little bit weird. It looks like it's just a boolean check and at the end it prints some dom.
Could not it be tooltipWrapper or something like this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it's better, I'll fix it thanks !!

@RemiBonnet RemiBonnet merged commit 3619658 into staging Dec 1, 2022
@RemiBonnet RemiBonnet deleted the feat/menu-hover-label branch December 1, 2022 15:54
@bdebon
Copy link
Contributor

bdebon commented Dec 1, 2022

🎉 This PR is included in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@bdebon bdebon added the released label Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdebon bdebon bdebon approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RemiBonnet @evoxmusic @bdebon