Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(onboarding): add new step pricing #425

Merged
merged 8 commits into from Dec 21, 2022
Merged

Conversation

RemiBonnet
Copy link
Member

@RemiBonnet RemiBonnet commented Dec 20, 2022

What does this PR do?

> Link to the JIRA ticket

  • Merge onboarding application with V3
  • Add new step for Pricing

Capture d’écran 2022-12-20 à 14 40 05


PR Checklist

Global

  • This PR does not introduce any breaking change
  • This PR introduces breaking change(s) and has been labeled as such
  • I have found someone to review this PR and pinged him

Store

  • This PR introduces new store changes

NX

  • I have run the dep-graph locally and made sure the tree was clean i.e no circular dependencies
  • I have followed the library pattern i.e feature, ui, data, utils

Clean Code

  • I made sure the code is type safe (no any)
  • I have included a feature flag on my feature, if applicable

@evoxmusic
Copy link
Contributor

A preview environment was automatically created via Qovery.
Click on the link below to follow its deployment and use it.
👉 [PR] staging - feat(onboarding): add new step pricing - 2022-12-20T08:48:37Z

Another comment will be posted when deployments are terminated

@nx-cloud
Copy link

nx-cloud bot commented Dec 20, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 12bfeea. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@evoxmusic
Copy link
Contributor

Your preview environment has been successfully deployed !
Click on the link below to open your service:
👉 console
👉 storybook

@RemiBonnet RemiBonnet marked this pull request as ready for review December 20, 2022 13:44
Copy link
Contributor

@bdebon bdebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to say, worked really well. The only thing that could have been done maybe is to reuse the FunnelFlow component to have only one iteration of this kind of layout. But it's a lot of changes for not so much benefits. Let's go!

@RemiBonnet RemiBonnet merged commit 6dc1e88 into staging Dec 21, 2022
@RemiBonnet RemiBonnet deleted the feat/onboarding-FRT-589 branch December 21, 2022 14:04
@bdebon
Copy link
Contributor

bdebon commented Dec 21, 2022

🎉 This PR is included in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants