New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(project): modal to create project #426
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e73ddf3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
A preview environment was automatically created via Qovery. Another comment will be posted when deployments are terminated |
Codecov Report
@@ Coverage Diff @@
## staging #426 +/- ##
===========================================
+ Coverage 52.50% 52.65% +0.14%
===========================================
Files 326 329 +3
Lines 6215 6243 +28
Branches 1354 1355 +1
===========================================
+ Hits 3263 3287 +24
- Misses 2513 2517 +4
Partials 439 439
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
44a0ac9
to
bb09480
Compare
419d632
to
873342c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review is RAS good!
Testing the UI, gave me this weird cursor issue
https://user-images.githubusercontent.com/6163954/209195560-2685bc3e-f1f5-46bb-acae-25a419d8a3ce.mp4
There is a weird behavior here, if you scroll down in the menu, it scrolls down the whole page and when you click on the element, you have the content of the page not scrolled up
https://user-images.githubusercontent.com/6163954/209195947-ec63e639-4445-4e89-8d7b-98b63a15a141.mp4
The rest is perfect I could create and delete and edit project pretty easily! Nice work! I like this ui/ux, super efficient.
🎉 This PR is included in version 1.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
What does this PR do?
PR Checklist
Global
Store
NX
feature
,ui
,data
,utils
Clean Code