Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(project): modal to create project #426

Merged
merged 10 commits into from Dec 22, 2022
Merged

Conversation

RemiBonnet
Copy link
Member

@RemiBonnet RemiBonnet commented Dec 20, 2022

What does this PR do?

  • Add a modal to create a project
  • Update NavigationLeft component to add left link

Capture d’écran 2022-12-21 à 17 12 43


PR Checklist

Global

  • This PR does not introduce any breaking change
  • This PR introduces breaking change(s) and has been labeled as such
  • I have found someone to review this PR and pinged him

Store

  • This PR introduces new store changes

NX

  • I have run the dep-graph locally and made sure the tree was clean i.e no circular dependencies
  • I have followed the library pattern i.e feature, ui, data, utils

Clean Code

  • I made sure the code is type safe (no any)
  • I have included a feature flag on my feature, if applicable

@nx-cloud
Copy link

nx-cloud bot commented Dec 20, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e73ddf3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@evoxmusic
Copy link
Contributor

A preview environment was automatically created via Qovery.
Click on the link below to follow its deployment and use it.
👉 [PR] staging - feat(project): modal to create project - 2022-12-20T16:04:11Z

Another comment will be posted when deployments are terminated

@evoxmusic
Copy link
Contributor

Your preview environment has been successfully deployed !
Click on the link below to open your service:
👉 console
👉 storybook

@RemiBonnet RemiBonnet marked this pull request as ready for review December 21, 2022 16:13
@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2022

Codecov Report

Merging #426 (e73ddf3) into staging (861c047) will increase coverage by 0.14%.
The diff coverage is 87.09%.

@@             Coverage Diff             @@
##           staging     #426      +/-   ##
===========================================
+ Coverage    52.50%   52.65%   +0.14%     
===========================================
  Files          326      329       +3     
  Lines         6215     6243      +28     
  Branches      1354     1355       +1     
===========================================
+ Hits          3263     3287      +24     
- Misses        2513     2517       +4     
  Partials       439      439              
Impacted Files Coverage Δ
apps/console/src/app/app.tsx 46.15% <ø> (ø)
.../domains/projects/src/lib/slices/projects.slice.ts 29.23% <0.00%> (-0.46%) ⬇️
libs/pages/settings/src/lib/page-settings.tsx 70.00% <ø> (ø)
...s/layout/src/lib/feature/breadcrumb/breadcrumb.tsx 90.90% <66.66%> (-9.10%) ⬇️
.../pages/settings/src/lib/ui/container/container.tsx 80.00% <66.66%> (-20.00%) ⬇️
...ect-modal/feature/create-project-modal-feature.tsx 92.30% <92.30%> (ø)
apps/console/src/app/components/scroll-to-top.tsx 100.00% <100.00%> (ø)
...tion/src/lib/feature/tabs-feature/tabs-feature.tsx 40.00% <100.00%> (ø)
...feature/create-clone-environment-modal-feature.tsx 77.77% <100.00%> (-0.80%) ⬇️
...b/create-project-modal/ui/create-project-modal.tsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@RemiBonnet RemiBonnet force-pushed the feat/modal-create-project branch 2 times, most recently from 44a0ac9 to bb09480 Compare December 22, 2022 13:07
Copy link
Contributor

@bdebon bdebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review is RAS good!

Testing the UI, gave me this weird cursor issue
https://user-images.githubusercontent.com/6163954/209195560-2685bc3e-f1f5-46bb-acae-25a419d8a3ce.mp4

There is a weird behavior here, if you scroll down in the menu, it scrolls down the whole page and when you click on the element, you have the content of the page not scrolled up
https://user-images.githubusercontent.com/6163954/209195947-ec63e639-4445-4e89-8d7b-98b63a15a141.mp4

The rest is perfect I could create and delete and edit project pretty easily! Nice work! I like this ui/ux, super efficient.

@RemiBonnet RemiBonnet merged commit 5286300 into staging Dec 22, 2022
@RemiBonnet RemiBonnet deleted the feat/modal-create-project branch December 22, 2022 18:15
@bdebon
Copy link
Contributor

bdebon commented Dec 23, 2022

🎉 This PR is included in version 1.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants