Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(console-shared): folder architecture #427

Merged
merged 5 commits into from Dec 26, 2022
Merged

Conversation

RemiBonnet
Copy link
Member

@RemiBonnet RemiBonnet commented Dec 23, 2022

What does this PR do?

  • Here is an example of how to structure components for the console-shared library
  • Cleaning for git-repository-settings and buttons-actions

Capture d’écran 2022-12-23 à 11 22 59

Capture d’écran 2022-12-23 à 11 23 27


PR Checklist

Global

  • This PR does not introduce any breaking change
  • This PR introduces breaking change(s) and has been labeled as such
  • I have found someone to review this PR and pinged him

Store

  • This PR introduces new store changes

NX

  • I have run the dep-graph locally and made sure the tree was clean i.e no circular dependencies
  • I have followed the library pattern i.e feature, ui, data, utils

Clean Code

  • I made sure the code is type safe (no any)
  • I have included a feature flag on my feature, if applicable

@evoxmusic
Copy link
Contributor

A preview environment was automatically created via Qovery.
Click on the link below to follow its deployment and use it.
👉 [PR] staging - fix(console-shared): folder architecture - 2022-12-23T10:23:45Z

Another comment will be posted when deployments are terminated

@nx-cloud
Copy link

nx-cloud bot commented Dec 23, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9fdbd7f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@evoxmusic
Copy link
Contributor

Your preview environment has been successfully deployed !
Click on the link below to open your service:
👉 console
👉 storybook

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2022

Codecov Report

Merging #427 (9fdbd7f) into staging (311c7a9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           staging     #427   +/-   ##
========================================
  Coverage    52.70%   52.71%           
========================================
  Files          329      329           
  Lines         6255     6254    -1     
  Branches      1361     1362    +1     
========================================
  Hits          3297     3297           
  Misses        2517     2517           
+ Partials       441      440    -1     
Impacted Files Coverage Δ
...ture/step-general-feature/step-general-feature.tsx 57.69% <ø> (ø)
...te-feature/step-port-feature/step-port-feature.tsx 60.00% <ø> (ø)
.../step-resources-feature/step-resources-feature.tsx 66.66% <ø> (ø)
...ture/step-summary-feature/step-summary-feature.tsx 58.06% <ø> (ø)
...ture/step-general-feature/step-general-feature.tsx 43.10% <ø> (ø)
.../step-resources-feature/step-resources-feature.tsx 82.35% <ø> (ø)
...ture/step-summary-feature/step-summary-feature.tsx 64.28% <ø> (ø)
libs/pages/services/src/lib/router/router.tsx 100.00% <ø> (ø)
...e-application-create/step-general/step-general.tsx 90.90% <ø> (ø)
...plication-create/step-resources/step-resources.tsx 100.00% <ø> (ø)
... and 18 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@bdebon bdebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect Remi, super initiative. I'm gonna continue the renaming/refactoring on another PR

@bdebon bdebon merged commit eaa3c8a into staging Dec 26, 2022
@bdebon bdebon deleted the fix/shared-console-library branch December 26, 2022 13:56
@bdebon
Copy link
Contributor

bdebon commented Dec 26, 2022

🎉 This PR is included in version 1.6.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants