Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(settings-description): field description #428

Merged
merged 8 commits into from Dec 26, 2022

Conversation

RemiBonnet
Copy link
Member

What does this PR do?

> Link to the JIRA ticket

  • Fix Job general settings
  • Add field description for Application and Containers

PR Checklist

Global

  • This PR does not introduce any breaking change
  • This PR introduces breaking change(s) and has been labeled as such
  • I have found someone to review this PR and pinged him

Store

  • This PR introduces new store changes

NX

  • I have run the dep-graph locally and made sure the tree was clean i.e no circular dependencies
  • I have followed the library pattern i.e feature, ui, data, utils

Clean Code

  • I made sure the code is type safe (no any)
  • I have included a feature flag on my feature, if applicable

@evoxmusic
Copy link
Contributor

A preview environment was automatically created via Qovery.
Click on the link below to follow its deployment and use it.
👉 [PR] staging - fix(settings-description): field description - 2022-12-23T12:19:03Z

Another comment will be posted when deployments are terminated

@nx-cloud
Copy link

nx-cloud bot commented Dec 23, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8fad91a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@evoxmusic
Copy link
Contributor

Your preview environment has been successfully deployed !
Click on the link below to open your service:
👉 console
👉 storybook

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2022

Codecov Report

Merging #428 (8fad91a) into staging (46f86ab) will increase coverage by 0.03%.
The diff coverage is 68.75%.

@@             Coverage Diff             @@
##           staging     #428      +/-   ##
===========================================
+ Coverage    52.67%   52.70%   +0.03%     
===========================================
  Files          329      329              
  Lines         6242     6255      +13     
  Branches      1355     1361       +6     
===========================================
+ Hits          3288     3297       +9     
  Misses        2517     2517              
- Partials       437      441       +4     
Impacted Files Coverage Δ
...s/application/src/lib/slices/applications.slice.ts 18.22% <0.00%> (ø)
.../clusters/src/lib/ui/card-cluster/card-cluster.tsx 90.00% <ø> (ø)
...b/ui/page-job-create/step-general/step-general.tsx 75.00% <ø> (ø)
...ntainer-settings/ui/general-container-settings.tsx 66.66% <ø> (ø)
libs/shared/utils/src/lib/tools/refacto-payload.ts 46.34% <0.00%> (-2.38%) ⬇️
...-general-feature/page-settings-general-feature.tsx 36.45% <60.00%> (+0.97%) ⬆️
...ui/page-settings-general/page-settings-general.tsx 70.58% <100.00%> (+1.83%) ⬆️
...-general-feature/page-settings-general-feature.tsx 81.81% <100.00%> (+0.86%) ⬆️
...ui/page-settings-general/page-settings-general.tsx 80.00% <100.00%> (+1.42%) ⬆️
...ion-post-feature/page-application-post-feature.tsx 58.06% <100.00%> (+1.39%) ⬆️
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@bdebon bdebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! You can merge amigo!

@RemiBonnet RemiBonnet merged commit 311c7a9 into staging Dec 26, 2022
@RemiBonnet RemiBonnet deleted the fix/create-settings-input-description branch December 26, 2022 13:07
@bdebon
Copy link
Contributor

bdebon commented Dec 26, 2022

🎉 This PR is included in version 1.6.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants