Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(page-environment): placeholder to create a cluster and environment #432

Merged
merged 2 commits into from Dec 27, 2022

Conversation

RemiBonnet
Copy link
Member

@RemiBonnet RemiBonnet commented Dec 27, 2022

What does this PR do?

> Link to the JIRA ticket

  • Add a placeholder to create a cluster
  • Add a placeholder to create an environment
  • Add a banner to indicate cluster installation is ongoing

Capture d’écran 2022-12-27 à 13 43 28


PR Checklist

Global

  • This PR does not introduce any breaking change
  • This PR introduces breaking change(s) and has been labeled as such
  • I have found someone to review this PR and pinged him

Store

  • This PR introduces new store changes

NX

  • I have run the dep-graph locally and made sure the tree was clean i.e no circular dependencies
  • I have followed the library pattern i.e feature, ui, data, utils

Clean Code

  • I made sure the code is type safe (no any)
  • I have included a feature flag on my feature, if applicable

@evoxmusic
Copy link
Contributor

A preview environment was automatically created via Qovery.
Click on the link below to follow its deployment and use it.
👉 [PR] staging - feat(page-environment): placeholder to create Cluster and Environment - 2022-12-27T12:45:43Z

Another comment will be posted when deployments are terminated

@nx-cloud
Copy link

nx-cloud bot commented Dec 27, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ab84203. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@RemiBonnet RemiBonnet changed the title feat(page-environment): placeholder to create Cluster and Environment feat(page-environment): placeholder to create a cluster and environment Dec 27, 2022
@RemiBonnet RemiBonnet marked this pull request as ready for review December 27, 2022 12:48
@codecov-commenter
Copy link

Codecov Report

Merging #432 (ab84203) into staging (1dea86d) will increase coverage by 0.10%.
The diff coverage is 55.88%.

@@             Coverage Diff             @@
##           staging     #432      +/-   ##
===========================================
+ Coverage    52.72%   52.83%   +0.10%     
===========================================
  Files          332      332              
  Lines         6291     6314      +23     
  Branches      1379     1388       +9     
===========================================
+ Hits          3317     3336      +19     
- Misses        2522     2529       +7     
+ Partials       452      449       -3     
Impacted Files Coverage Δ
...ironments/src/lib/ui/page-general/page-general.tsx 48.00% <23.07%> (-13.12%) ⬇️
...ages/layout/src/lib/ui/layout-page/layout-page.tsx 61.53% <54.54%> (-38.47%) ⬇️
...ture/page-general-feature/page-general-feature.tsx 93.33% <100.00%> (+1.02%) ⬆️
...s/pages/environments/src/lib/page-environments.tsx 100.00% <100.00%> (ø)
...es/environments/src/lib/ui/container/container.tsx 90.90% <100.00%> (+12.33%) ⬆️
...ibs/pages/layout/src/lib/feature/layout/layout.tsx 55.88% <100.00%> (+2.75%) ⬆️
.../page-settings-advanced/page-settings-advanced.tsx 92.85% <0.00%> (+0.54%) ⬆️
...luster-buttons-actions/cluster-buttons-actions.tsx 66.66% <0.00%> (+7.14%) ⬆️
libs/pages/logs/infra/src/lib/ui/row/row.tsx 100.00% <0.00%> (+10.52%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@evoxmusic
Copy link
Contributor

Your preview environment has been successfully deployed !
Click on the link below to open your service:
👉 console
👉 storybook

Copy link
Contributor

@bdebon bdebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good! works well and RAS in the code!

@RemiBonnet RemiBonnet merged commit 8a4b960 into staging Dec 27, 2022
@RemiBonnet RemiBonnet deleted the feat/onboarding-flow-FRT-592 branch December 27, 2022 14:22
@bdebon
Copy link
Contributor

bdebon commented Dec 27, 2022

🎉 This PR is included in version 1.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants