Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(job): overview for jobs #433

Merged
merged 6 commits into from Dec 27, 2022
Merged

feat(job): overview for jobs #433

merged 6 commits into from Dec 27, 2022

Conversation

bdebon
Copy link
Contributor

@bdebon bdebon commented Dec 27, 2022

What does this PR do?

  • Created a property-card component to display this kind of property card value

CleanShot 2022-12-27 at 15 17 36@2x

  • Created a JobOverview component to gather everything about job without overloading too much the page-general component
  • Unit testing

https://qovery.atlassian.net/jira/software/projects/FRT/boards/23?selectedIssue=FRT-624

CleanShot 2022-12-27 at 15 18 37@2x


PR Checklist

Global

  • This PR does not introduce any breaking change
  • This PR introduces breaking change(s) and has been labeled as such
  • I have found someone to review this PR and pinged him

Store

  • This PR introduces new store changes

NX

  • I have run the dep-graph locally and made sure the tree was clean i.e no circular dependencies
  • I have followed the library pattern i.e feature, ui, data, utils

Clean Code

  • I made sure the code is type safe (no any)
  • I have included a feature flag on my feature, if applicable

@evoxmusic
Copy link
Contributor

A preview environment was automatically created via Qovery.
Click on the link below to follow its deployment and use it.
👉 [PR] staging - feat(job): overview for jobs - 2022-12-27T14:19:15Z

Another comment will be posted when deployments are terminated

@nx-cloud
Copy link

nx-cloud bot commented Dec 27, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 817868e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@evoxmusic
Copy link
Contributor

Your preview environment has been successfully deployed !
Click on the link below to open your service:
👉 console
👉 storybook

Copy link
Member

@RemiBonnet RemiBonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @bdebon, I don't have important notes!

Just two points :

  • Can you add two by two cards for small screen ?

Capture d’écran 2022-12-27 à 15 34 15

  • And, I know it's on the design but it's better if we have an uppercase unit ?

Capture d’écran 2022-12-27 à 15 35 28

@codecov-commenter
Copy link

Codecov Report

Merging #433 (16e0c25) into staging (5162624) will increase coverage by 0.02%.
The diff coverage is 41.93%.

@@             Coverage Diff             @@
##           staging     #433      +/-   ##
===========================================
+ Coverage    52.73%   52.75%   +0.02%     
===========================================
  Files          332      333       +1     
  Lines         6292     6344      +52     
  Branches      1380     1405      +25     
===========================================
+ Hits          3318     3347      +29     
- Misses        2522     2537      +15     
- Partials       452      460       +8     
Impacted Files Coverage Δ
...plication/src/lib/ui/job-overview/job-overview.tsx 40.74% <40.74%> (ø)
...plication/src/lib/ui/page-general/page-general.tsx 46.15% <50.00%> (+0.69%) ⬆️
...ages/layout/src/lib/ui/layout-page/layout-page.tsx 61.53% <0.00%> (-38.47%) ⬇️
...ironments/src/lib/ui/page-general/page-general.tsx 48.00% <0.00%> (-13.12%) ⬇️
...ture/menu-account-feature/menu-account-feature.tsx 60.00% <0.00%> (-11.43%) ⬇️
...s/console/src/app/components/redirect-overview.tsx 0.00% <0.00%> (ø)
...s/pages/environments/src/lib/page-environments.tsx 100.00% <0.00%> (ø)
...ture/page-general-feature/page-general-feature.tsx 93.33% <0.00%> (+1.02%) ⬆️
...ibs/pages/layout/src/lib/feature/layout/layout.tsx 55.88% <0.00%> (+2.75%) ⬆️
.../clusters/src/lib/ui/card-cluster/card-cluster.tsx 100.00% <0.00%> (+10.00%) ⬆️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bdebon bdebon merged commit ed39de4 into staging Dec 27, 2022
@bdebon bdebon deleted the feat/job-overview branch December 27, 2022 14:54
@bdebon
Copy link
Contributor Author

bdebon commented Dec 27, 2022

🎉 This PR is included in version 1.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants