New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(job): overview for jobs #433
Conversation
A preview environment was automatically created via Qovery. Another comment will be posted when deployments are terminated |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 817868e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done @bdebon, I don't have important notes!
Just two points :
- Can you add two by two cards for small screen ?
- And, I know it's on the design but it's better if we have an uppercase unit ?
libs/pages/application/src/lib/ui/job-overview/job-overview.tsx
Outdated
Show resolved
Hide resolved
libs/pages/application/src/lib/ui/job-overview/job-overview.tsx
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## staging #433 +/- ##
===========================================
+ Coverage 52.73% 52.75% +0.02%
===========================================
Files 332 333 +1
Lines 6292 6344 +52
Branches 1380 1405 +25
===========================================
+ Hits 3318 3347 +29
- Misses 2522 2537 +15
- Partials 452 460 +8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
🎉 This PR is included in version 1.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
What does this PR do?
property-card
component to display this kind of property card valueJobOverview
component to gather everything about job without overloading too much thepage-general
componenthttps://qovery.atlassian.net/jira/software/projects/FRT/boards/23?selectedIssue=FRT-624
PR Checklist
Global
Store
NX
feature
,ui
,data
,utils
Clean Code