Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-clone-environment-modal): redirect after request #436

Merged
merged 1 commit into from Jan 2, 2023

Conversation

RemiBonnet
Copy link
Member

What does this PR do?

  • Redirection to the Services page after cloning or creating Environment

Capture d’écran 2023-01-02 à 09 19 52


PR Checklist

Global

  • This PR does not introduce any breaking change
  • This PR introduces breaking change(s) and has been labeled as such
  • I have found someone to review this PR and pinged him

Store

  • This PR introduces new store changes

NX

  • I have run the dep-graph locally and made sure the tree was clean i.e no circular dependencies
  • I have followed the library pattern i.e feature, ui, data, utils

Clean Code

  • I made sure the code is type safe (no any)
  • I have included a feature flag on my feature, if applicable

@evoxmusic
Copy link
Contributor

A preview environment was automatically created via Qovery.
Click on the link below to follow its deployment and use it.
👉 [PR] staging - fix(create-clone-environment-modal): redirect after request - 2023-01-02T08:20:33Z

Another comment will be posted when deployments are terminated

@nx-cloud
Copy link

nx-cloud bot commented Jan 2, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 234a8b1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@RemiBonnet RemiBonnet requested a review from bdebon January 2, 2023 08:20
@RemiBonnet RemiBonnet marked this pull request as ready for review January 2, 2023 08:20
@codecov-commenter
Copy link

Codecov Report

Merging #436 (234a8b1) into staging (2d00906) will increase coverage by 11.26%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           staging     #436       +/-   ##
============================================
+ Coverage    52.84%   64.11%   +11.26%     
============================================
  Files          333      216      -117     
  Lines         6354     3765     -2589     
  Branches      1412     1043      -369     
============================================
- Hits          3358     2414      -944     
+ Misses        2539      959     -1580     
+ Partials       457      392       -65     
Impacted Files Coverage Δ
...feature/create-clone-environment-modal-feature.tsx 80.00% <100.00%> (+2.22%) ⬆️
...luster-buttons-actions/cluster-buttons-actions.tsx 59.52% <0.00%> (-7.15%) ⬇️
.../projects/src/lib/slices/deployment-rules.slice.ts
...ding/src/lib/feature/form-company/form-company.tsx
.../feature/onboarding-project/onboarding-project.tsx
.../utils/src/lib/tools/one-to-many-redux-helpers.tsx
...g/src/lib/ui/step-personalize/step-personalize.tsx
...able/src/lib/slices/environment-variables.slice.ts
...eature/page-logout-feature/page-logout-feature.tsx
...d/utils/src/lib/tools/status-actions-available.tsx
... and 109 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@evoxmusic
Copy link
Contributor

Your preview environment has been successfully deployed !
Click on the link below to open your service:
👉 console
👉 storybook

Copy link
Contributor

@bdebon bdebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go!

@RemiBonnet RemiBonnet merged commit facc3bf into staging Jan 2, 2023
@RemiBonnet RemiBonnet deleted the fix/create-clone-environment-redirect branch January 2, 2023 08:57
@bdebon
Copy link
Contributor

bdebon commented Jan 4, 2023

🎉 This PR is included in version 1.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@bdebon bdebon added the released label Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants