Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(member): invite member to an organization #438

Closed
wants to merge 8 commits into from

Conversation

bdebon
Copy link
Contributor

@bdebon bdebon commented Jan 4, 2023

What does this PR do?

> Link to the JIRA ticket

This PR implements the acceptation flow of an invitation. The development of this feature was highly complexified with a bug with auth0 and getTokenSilently with ignoreCache: true in local only. In Local it works only on chrome (and not on private navigation mode). Does not work locally on firefox / safari / brave.

This pr still needs some real unit testing and some refinement for the login screen with the invitation message displayed. Design has changed at the last moment.

CleanShot 2023-01-04 at 18 24 46@2x


PR Checklist

Global

  • This PR does not introduce any breaking change
  • This PR introduces breaking change(s) and has been labeled as such
  • I have found someone to review this PR and pinged him

Store

  • This PR introduces new store changes

NX

  • I have run the dep-graph locally and made sure the tree was clean i.e no circular dependencies
  • I have followed the library pattern i.e feature, ui, data, utils

Clean Code

  • I made sure the code is type safe (no any)
  • I have included a feature flag on my feature, if applicable

@evoxmusic
Copy link
Contributor

A preview environment was automatically created via Qovery.
Click on the link below to follow its deployment and use it.
👉 [PR] staging - feat(member): invite member to an organization - 2023-01-04T17:25:05Z

Another comment will be posted when deployments are terminated

@nx-cloud
Copy link

nx-cloud bot commented Jan 4, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 14a4572. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@bdebon bdebon marked this pull request as draft January 4, 2023 17:25
@evoxmusic
Copy link
Contributor

Your preview environment has been successfully deployed !
Click on the link below to open your service:
👉 console
👉 storybook

@bdebon bdebon marked this pull request as ready for review January 9, 2023 16:56
@codecov-commenter
Copy link

Codecov Report

Merging #438 (14a4572) into staging (72e6a10) will increase coverage by 0.47%.
The diff coverage is 62.65%.

@@             Coverage Diff             @@
##           staging     #438      +/-   ##
===========================================
+ Coverage    52.81%   53.28%   +0.47%     
===========================================
  Files          335      340       +5     
  Lines         6413     6497      +84     
  Branches      1433     1446      +13     
===========================================
+ Hits          3387     3462      +75     
- Misses        2564     2569       +5     
- Partials       462      466       +4     
Impacted Files Coverage Δ
apps/console/src/app/router/main.router.tsx 100.00% <ø> (ø)
...interceptors/auth-interceptor/auth-interceptor.tsx 25.92% <0.00%> (-2.08%) ⬇️
...itation/ui/accept-invitation/accept-invitation.tsx 50.00% <50.00%> (ø)
.../invite-details/feature/invite-details-feature.tsx 50.00% <50.00%> (ø)
...th/src/lib/use-invite-member/use-invite-member.tsx 62.90% <62.90%> (ø)
...t-invitation/feature/accept-invitation-feature.tsx 75.00% <75.00%> (ø)
apps/console/src/app/app.tsx 48.14% <100.00%> (+1.99%) ⬆️
libs/pages/login/src/lib/ui/login/login.tsx 57.14% <100.00%> (+17.14%) ⬆️
...hared/src/lib/invite-details/ui/invite-details.tsx 100.00% <100.00%> (ø)
libs/shared/router/src/lib/router.ts 40.00% <100.00%> (+15.00%) ⬆️
... and 8 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@RemiBonnet RemiBonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @bdebon, small improvements on the review but LGTM 👍

  • When we have this page can you redirect to the login or other?

Capture d’écran 2023-01-12 à 11 04 50

@bdebon bdebon closed this Jan 18, 2023
@RemiBonnet RemiBonnet deleted the feat/invite-member branch March 24, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants