New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(member): invite member to an organization #438
Conversation
A preview environment was automatically created via Qovery. Another comment will be posted when deployments are terminated |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 14a4572. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Codecov Report
@@ Coverage Diff @@
## staging #438 +/- ##
===========================================
+ Coverage 52.81% 53.28% +0.47%
===========================================
Files 335 340 +5
Lines 6413 6497 +84
Branches 1433 1446 +13
===========================================
+ Hits 3387 3462 +75
- Misses 2564 2569 +5
- Partials 462 466 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done @bdebon, small improvements on the review but LGTM 👍
- When we have this page can you redirect to the login or other?
What does this PR do?
> Link to the JIRA ticket
This PR implements the acceptation flow of an invitation. The development of this feature was highly complexified with a bug with auth0 and
getTokenSilently
withignoreCache: true
in local only. In Local it works only on chrome (and not on private navigation mode). Does not work locally on firefox / safari / brave.This pr still needs some real unit testing and some refinement for the login screen with the invitation message displayed. Design has changed at the last moment.
PR Checklist
Global
Store
NX
feature
,ui
,data
,utils
Clean Code