New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Environment services table #80
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f2dd470. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
A preview environment was automatically created via Qovery. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, for the screenshot we need your integration and not the Figma
The commit component is glitched, we need the have the same width for the hover and click, we don't have the same experience with the V2
return ( | ||
<Tooltip content="Copy"> | ||
<div | ||
data-testid="tagcommit" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can add directly tag-commit
@@ -0,0 +1,14 @@ | |||
import { IconProps } from '../icon' | |||
|
|||
function DockerIcon(props: IconProps) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing other logos, check with the currently production (Redis, Postgre, etc)
When we are loading the data for the first time, the table is empty which is wrong. We should see 2 or 3 lines of placeholders skeletons. The skeletons are all stacked without spaces between them. |
On hover there is a slight change of global width which create a very unpleasant shift, probably you should fix the width of both icon to avoid this behavior |
Everything is good now! You can merge! Well done! |
🎉 This PR is included in version 1.0.0-staging.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
What does this PR do?
> Link to the JIRA ticket
PR Checklist
Global
Store
NX
feature
,ui
,data
,utils
Clean Code