Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment services table #80

Merged
merged 4 commits into from May 16, 2022
Merged

Conversation

WilliamTraoreee
Copy link
Contributor

@WilliamTraoreee WilliamTraoreee commented May 13, 2022

What does this PR do?

> Link to the JIRA ticket

  • Create the environment service table (all services link to an environment)
  • Create Tag commit component with the copy commit id feature

image

PR Checklist

Global

  • This PR does not introduce any breaking change
  • This PR introduces breaking change(s) and has been labeled as such
  • I have found someone to review this PR and pinged him

Store

  • This PR introduces new store changes

NX

  • I have run the dep-graph locally and made sure the tree was clean i.e no circular dependencies
  • I have followed the library pattern i.e feature, ui, data, utils

Clean Code

  • I made sure the code is type safe (no any)
  • I have included a feature flag on my feature, if applicable

@nx-cloud
Copy link

nx-cloud bot commented May 13, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f2dd470. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@RemiBonnet
Copy link
Member

A preview environment was automatically created via Qovery.
Click on the link below to follow its deployment and use it.
👉 [PR] staging - Environment services table - 2022-05-13T12:48:55Z

@WilliamTraoreee WilliamTraoreee marked this pull request as ready for review May 13, 2022 12:59
@RemiBonnet
Copy link
Member

RemiBonnet commented May 13, 2022

Copy link
Member

@RemiBonnet RemiBonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, for the screenshot we need your integration and not the Figma

The commit component is glitched, we need the have the same width for the hover and click, we don't have the same experience with the V2

return (
<Tooltip content="Copy">
<div
data-testid="tagcommit"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can add directly tag-commit

@@ -0,0 +1,14 @@
import { IconProps } from '../icon'

function DockerIcon(props: IconProps) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing other logos, check with the currently production (Redis, Postgre, etc)

@bdebon
Copy link
Contributor

bdebon commented May 16, 2022

When we are loading the data for the first time, the table is empty which is wrong. We should see 2 or 3 lines of placeholders skeletons.
https://user-images.githubusercontent.com/6163954/168549612-0897b645-515f-478e-a02a-8a534b9cf3d0.mp4

The skeletons are all stacked without spaces between them.

@bdebon
Copy link
Contributor

bdebon commented May 16, 2022

On hover there is a slight change of global width which create a very unpleasant shift, probably you should fix the width of both icon to avoid this behavior
https://user-images.githubusercontent.com/6163954/168550202-f1b796af-ad7d-4ec2-94de-d55d08b91044.mp4

@bdebon
Copy link
Contributor

bdebon commented May 16, 2022

Everything is good now! You can merge! Well done!

@bdebon bdebon merged commit fdd87f2 into staging May 16, 2022
@bdebon bdebon deleted the feat/environment-services-table-FRT-344 branch May 16, 2022 12:57
@bdebon
Copy link
Contributor

bdebon commented Jun 22, 2022

🎉 This PR is included in version 1.0.0-staging.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@bdebon
Copy link
Contributor

bdebon commented Nov 17, 2022

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants