Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a Lightbox Pop-Up Modal #9

Closed
Qoyyuum opened this issue Oct 1, 2019 · 4 comments · Fixed by #10
Closed

Add a Lightbox Pop-Up Modal #9

Qoyyuum opened this issue Oct 1, 2019 · 4 comments · Fixed by #10
Assignees
@NitinNair89
Labels
enhancement hacktoberfest For hacktoberfest

Comments

@Qoyyuum
Copy link
Owner

Qoyyuum commented Oct 1, 2019

When the code is generated, it should be able to pop-up into a lightbox like modal instead of generating a new tab page for the source code to appear.

Optionally, add the ability to click to copy to clipboard.
@Qoyyuum Qoyyuum added enhancement hacktoberfest For hacktoberfest labels Oct 1, 2019
@NitinNair89
Copy link
Contributor

Hi,
I would like to attempt and work on this.

@Qoyyuum
Copy link
Owner Author

Qoyyuum commented Oct 2, 2019

Hi,
I would like to attempt and work on this.

Go ahead.

@NitinNair89
Copy link
Contributor

Thanks, please assign this issue to me. :)

@NitinNair89 NitinNair89 mentioned this issue Oct 3, 2019
Merged
@NitinNair89
Copy link
Contributor

Hi @Qoyyuum
Please review my PR and let me know your suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NitinNair89 NitinNair89

Labels
enhancement hacktoberfest For hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a Lightbox Pop-Up Modal NitinNair89/tablegenerator
2 participants
@Qoyyuum @NitinNair89