Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] CompatHelper #375

Closed
Roger-luo opened this issue Jul 8, 2022 · 11 comments · Fixed by #565
Closed

[Feature Request] CompatHelper #375

Roger-luo opened this issue Jul 8, 2022 · 11 comments · Fixed by #565
Assignees
Labels
CI/CD CI/CD issues enhancement New feature or request unitaryhack

Comments

@Roger-luo
Copy link
Member

need to setup CompatHelper for this repo. I need to check how subdir works for CompatHelper.

@Roger-luo Roger-luo added enhancement New feature or request CI/CD CI/CD issues labels Jul 8, 2022
@manulpatel
Copy link
Contributor

Hello @Roger-luo! I would be happy to work on this. Could you please assign me?

@ACE07-Sev
Copy link

ACE07-Sev commented May 27, 2023

I'd like to work on this as well. Can you kindly assign me to it?

@Roger-luo
Copy link
Member Author

@ACE07-Sev there is already a PR trying to fix this (but it is not working) if you also want to work on this you can submit a new PR, but I'd encourage you to take a different issue

@manulpatel
Copy link
Contributor

manulpatel commented May 28, 2023

@Roger-luo I have updated my PR to also include subdirectories inside lib to scan in CompatHelper. Could you please review it?

@Roger-luo
Copy link
Member Author

@manulpatel
Copy link
Contributor

@Roger-luo Yes I have made changes and opened up a new PR. I hope this should work. It seemed prior had issues with "" quotes in subdirs.

@manulpatel
Copy link
Contributor

@Roger-luo. I have opened a fresh PR, which setups CompatHelper only for main repo i.e. at top dir. For subdirs I tred to follow this but there are errors when scannnig inside lib dir. Your insights on this would be very helpful.

@natestemen
Copy link

natestemen commented Jun 16, 2023

@manulpatel reminder that if you get this issue closed by June 20th, you'll be eligible for the unitaryHACK bounty!

@manulpatel
Copy link
Contributor

Thanks @natestemen for reminding! Actually I am stuck on this and not able to pass the CI tests for my changes.

@manulpatel
Copy link
Contributor

@Roger-luo Could you please assign me the issue and then close it? As this would allow Unitary Hack bots to discover this issue. @natestemen The PR for this issue is successfully merged as per the deadline of 20 June AoE. Kindly consider me in the Unitary Hack 2023 for this issue.

@Roger-luo
Copy link
Member Author

I just did that I'm not sure if this works or not, please let me know if it doesn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD CI/CD issues enhancement New feature or request unitaryhack
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants