-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] CompatHelper #375
Comments
Hello @Roger-luo! I would be happy to work on this. Could you please assign me? |
I'd like to work on this as well. Can you kindly assign me to it? |
@ACE07-Sev there is already a PR trying to fix this (but it is not working) if you also want to work on this you can submit a new PR, but I'd encourage you to take a different issue |
@Roger-luo I have updated my PR to also include subdirectories inside lib to scan in CompatHelper. Could you please review it? |
@manulpatel I don't think it works https://github.com/QuEraComputing/Bloqade.jl/actions/runs/5127411880/jobs/9223001629 |
@Roger-luo Yes I have made changes and opened up a new PR. I hope this should work. It seemed prior had issues with "" quotes in subdirs. |
@Roger-luo. I have opened a fresh PR, which setups CompatHelper only for main repo i.e. at top dir. For subdirs I tred to follow this but there are errors when scannnig inside |
@manulpatel reminder that if you get this issue closed by June 20th, you'll be eligible for the unitaryHACK bounty! |
Thanks @natestemen for reminding! Actually I am stuck on this and not able to pass the CI tests for my changes. |
@Roger-luo Could you please assign me the issue and then close it? As this would allow Unitary Hack bots to discover this issue. @natestemen The PR for this issue is successfully merged as per the deadline of 20 June AoE. Kindly consider me in the Unitary Hack 2023 for this issue. |
I just did that I'm not sure if this works or not, please let me know if it doesn't. |
need to setup CompatHelper for this repo. I need to check how subdir works for CompatHelper.
The text was updated successfully, but these errors were encountered: