Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display version behavior #1275

Merged
merged 7 commits into from May 24, 2022
Merged

Fix display version behavior #1275

merged 7 commits into from May 24, 2022

Conversation

viniciusdc
Copy link
Contributor

@viniciusdc viniciusdc commented May 11, 2022

Fixes | Closes | Resolves #1274

Changes introduced in this PR:

  • Add a condition to set theme version programmatically when display_version is True;
  • bump qhub-jupyterhub-theme==0.3.5 to fix the conflicting behavior for the dashboards page and version display;
  • Fix some doc typos

Types of changes

What types of changes does your PR introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Documentation

Does your contribution include breaking changes or deprecations?
If so have you updated the documentation?

  • Yes, docstrings
  • Yes, main documentation
  • Yes, deprecation notices

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered and more.

@viniciusdc viniciusdc requested a review from iameskild May 11, 2022 16:05
@viniciusdc viniciusdc changed the title Fix display version behaviour Fix display version behavior May 11, 2022
@viniciusdc viniciusdc added the needs: review 👀 This PR is complete and ready for reviewing label May 11, 2022
@iameskild
Copy link
Member

Thanks for this @viniciusdc! I'm not sure what is going on but I redeployed the beta deployment and it seems to have fixed the issue for some reason:
Screen Shot 2022-05-11 at 17 09 34

I'm not really sure what is going on here haha

@viniciusdc
Copy link
Contributor Author

viniciusdc commented May 13, 2022

Thanks for this @viniciusdc! I'm not sure what is going on but I redeployed the beta deployment and it seems to have fixed the issue for some reason: Screen Shot 2022-05-11 at 17 09 34

I'm not really sure what is going on here haha

I've manually committed the version tag to theme.jupyterhub so it's using that to propagate the version. This PR adds an auto-configuration in case display_version is passed but version is not. (Right now, it will default to v0.0.1 from the theme config when such key is not present)

@costrouc costrouc merged commit da59e67 into main May 24, 2022
@costrouc costrouc deleted the fix-1274-theme branch May 24, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: review 👀 This PR is complete and ready for reviewing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] (Maintenance) FIx display version behaviour
3 participants