Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secure ClearML behind forwardauth #721

Merged
merged 9 commits into from Jul 6, 2021
Merged

Secure ClearML behind forwardauth #721

merged 9 commits into from Jul 6, 2021

Conversation

aktech
Copy link
Member

@aktech aktech commented Jul 6, 2021

Fixes #666

  • Fixes ClearML TLS issue
  • Add forwardauth to ClearML

cc @danlester

@aktech aktech requested a review from danlester July 6, 2021 08:41
Copy link
Contributor

@danlester danlester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me - just wondered if there should be a different type for the TLS variable though.

@aktech aktech merged commit 28f4535 into main Jul 6, 2021
@aktech aktech deleted the clearml-auth branch July 13, 2021 12:27
leej3 added a commit that referenced this pull request Sep 10, 2021
leej3 added a commit that referenced this pull request Sep 15, 2021
leej3 added a commit that referenced this pull request Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Secure ClearML behind Auth
2 participants