Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FutureUniverseSelectionModel Doesn't Pass Canonical Symbol to OnSecuritiesChanged #6735

Closed
4 tasks done
DerekMelchin opened this issue Nov 10, 2022 · 2 comments · Fixed by #7313
Closed
4 tasks done

Comments

@DerekMelchin
Copy link
Collaborator

Expected Behavior

Whether we use AddFuture or AddUniverseSelection(FutureUniverseSelectionModel), we get the canonical Symbol in OnSecuritiesChanged.

Actual Behavior

We get the canonical Symbol if we use AddFuture, but not AddUniverseSelection(FutureUniverseSelectionModel).

Potential Solution

N/A

Reproducing the Problem

Run both cases in this backtest

System Information

QC Cloud

Checklist

  • I have completely filled out this template
  • I have confirmed that this issue exists on the current master branch
  • I have confirmed that this is not a duplicate issue by searching issues
  • I have provided detailed steps to reproduce the issue
@Martin-Molinero
Copy link
Member

Note that OptionUniverseSelectionModel has the same behavior as FutureUniverseSelectionModel

@Martin-Molinero
Copy link
Member

Note: This limits continuous future usage with the universe selection APIs. It seems currently the canonical security isn't even added to the algorithms.Securities collection. Believe though, the CreateUniverse implementation of the option/future selecitons could potentially directly call AddFuture/Option APIs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants