Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liquidate Method Does Not Have Asynchronous and OrderProperties Option #6818

Open
4 tasks done
AlexCatarino opened this issue Dec 22, 2022 · 0 comments
Open
4 tasks done

Comments

@AlexCatarino
Copy link
Member

Expected Behavior

The Liquidate method can place asynchronous orders not set the order properties.

Actual Behavior

Liquidate once place synchronous orders or set their properties.

Potential Solution

Option 1: The signature of the order methods in QCAlgorithm has the asynchronous parameter before the tag, so we should not add a parameter at the end. Instead, we need more method overloads.
Option 2: If the first argument is null, Liquidate should be asynchronous.

Reproducing the Problem

N/A. I noticed that a live algorithm wanted to open and close positions asynchronously. While there is an option using market orders to open the positions, it used Liquidate to close them and the orders were synchronous.

Checklist

  • I have completely filled out this template
  • I have confirmed that this issue exists on the current master branch
  • I have confirmed that this is not a duplicate issue by searching issues
  • I have provided detailed steps to reproduce the issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants