Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve exception message when generating Annual Performance Statistic #8022

Conversation

Marinovsky
Copy link
Collaborator

Description

The exception message thrown when the casting from double to decimal was done at PortfolioStatistics.GetAnnualPerformance(), didn't provide enough information regarding the reason behind the failure. Now, the message is more informative, pointing out explicitly which performance point is producing the error. Furthermore, the error was produced because of a bug in the quote file data.
image

Related Issue

Closes #7888

Motivation and Context

With this change if an exception is thrown while casting the annual performance to decimal, the exception message will be more informative.

Requires Documentation Change

N/A

How Has This Been Tested?

To test the exception message was the expected one the code provided in the issue was run.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

Copy link
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@Martin-Molinero Martin-Molinero merged commit cc3c97a into QuantConnect:master May 15, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error generating statistics: cast a floating-point as decimal
2 participants