Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share Notebook button #283

Open
natashawatkins opened this issue Oct 25, 2018 · 7 comments
Open

Share Notebook button #283

natashawatkins opened this issue Oct 25, 2018 · 7 comments
Assignees
Labels
enhancement New feature or request low-priority Can be done later

Comments

@natashawatkins
Copy link
Member

I think we should add a 'Share Notebook' button here, which would bring up a link to copy or a way to enter an email address - something to encourage sharing

image

@natashawatkins natashawatkins added enhancement New feature or request low-priority Can be done later labels Oct 25, 2018
@jstac
Copy link
Collaborator

jstac commented Oct 25, 2018

Nice idea. Probably just "Share" would be enough to give people the idea.

The only problem is that I don't remember any email addresses --- I've outsourced that part of my brain to Google too. And I'm too lazy to look them up...

@natashawatkins
Copy link
Member Author

A lot of websites just use a mailto: link I guess, and we could also have a twitter link like we have on QuantEcon.lectures... which is surprisingly used quite often

@AtlasMaxima-zz
Copy link
Collaborator

@natashawatkins @jstac we can implement share button that would link to the available social media corresponding to the same social media that we have i.e. Google and Twitter. I am not sure what you mean by the mailto: link?

@AtlasMaxima-zz
Copy link
Collaborator

AtlasMaxima-zz commented Jan 16, 2019

@DrDrij what styles should the Share notebook button have ? I see that Download, Notebook and Comments they all have their styles but Notebook and Comments are the same.

@DrDrij
Copy link
Member

DrDrij commented Jan 16, 2019

@natashawatkins Good suggestion! I reckon the key here is to share the page rather than the notebook. This way we promote traffic back to the site? I'd be happy with this being added to the button row as suggested with the action sharing a link to the corresponding notebook page on Notes. Any thoughts?

Ideally the share icon could bring up options to share on twitter/FB/email. We could latch onto https://www.addthis.com/ (or similar) to make this easier. I've implemented AddThis on a lot of corporate sites in the past. This is all client-side and leverages their services so we don't need to write this functionality.

@atlasmaxima I'd suggest for now to use the same style as the Download button. The colour differentiation being orange buttons correspond with actions on the site whereas the black button corresponds with "external" actions (being download and share).

<li><a class="alt">Share</a></li>

image

Perhaps once the functionality is in we could review the design of this button row altogether (adding icons for each action).

@AtlasMaxima-zz
Copy link
Collaborator

@DrDrij sharing the page sounds better than the notebook! I'll look into https://www.addthis.com/ or something similar.
Thanks!

@DrDrij
Copy link
Member

DrDrij commented Feb 20, 2019

@atlasmaxima Cool! If you implement it generally - I'm happy to "hack" the styling a bit so it matches the styling of the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low-priority Can be done later
Projects
None yet
Development

No branches or pull requests

4 participants