Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests of rouwenhorst fails occasionally #491

Closed
shizejin opened this issue Jul 4, 2019 · 3 comments · Fixed by #492
Closed

Tests of rouwenhorst fails occasionally #491

shizejin opened this issue Jul 4, 2019 · 3 comments · Fixed by #492

Comments

@shizejin
Copy link
Member

shizejin commented Jul 4, 2019

I found test error of rouwenhorst in build log of #489. There is no build error when I resubmit the exactly same commit for LQMarkov, and I guess this error is occasionally triggered by certain random values.

For example, the same error is triggered 7 times during 1000 runs.

Screen Shot 2019-07-04 at 15 22 26

@jstac
Copy link
Contributor

jstac commented Jul 4, 2019

Thanks @shizejin. It looks like tol should be increased to, say, 1e-10. Does that fix it?

@shizejin
Copy link
Member Author

shizejin commented Jul 4, 2019

@jstac Yes It works, the error only occur 5 times for 100000 runs after I increase tol to be 1e-10.

@jstac
Copy link
Contributor

jstac commented Jul 4, 2019

I think that's good enough.

@mmcky mmcky closed this as completed in #492 Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants