Add workaround for ipywidgets<=7.3.2 (#62)

* Add workaround for ipywidgets<=7.4.2

* make travis fail first

* fix handle_output bug

* Clean

* Fix tests

js/src/sheet.ts

@@ -299,8 +299,8 @@ let SheetView = widgets.DOMWidgetView.extend({
                             previous_view = null;
                         }
                     }
-                    if (!previous_view && widget && widget.widget_manager) {
-                        widget_view_promises[idx] = widget.widget_manager.create_view(widget)
+                    if (!previous_view && widget) {
+                        widget_view_promises[idx] = this.create_child_view(widget);
                     }
                 }
             }

js/src/test/dummy-manager.ts

@@ -105,6 +105,20 @@ class DummyManager extends widgets.ManagerBase<HTMLElement> {
         return Promise.resolve(new MockComm());
     }
 
+    setViewOptions(options) {
+        // mimics widgetsnbextension's manager that goes with ipywidgets<=7.3.2
+        var options = options || {};
+        if (!options.output && options.parent) {
+            // use the parent output if we don't have one
+            options.output = options.parent.options.output;
+        }
+        options.iopub_callbacks = {
+            output: options.output.handle_output.bind(options.output),
+            clear_output: options.output.handle_clear_output.bind(options.output)
+        }
+        return options;
+    }
+
     el: HTMLElement;
     library: any;
 }

js/src/test/utils.ts

@@ -1,7 +1,7 @@
 export
 async function make_view() {
-    const options = { model: this.sheet };
-    const view = await this.manager.create_view(this.sheet); //new ipysheet.SheetView(options);
+    const options = { model: this.sheet, output: {handle_output: () => {}, handle_clear_output: () => {}}};
+    const view = await this.manager.create_view(this.sheet, options); //new ipysheet.SheetView(options);
     await this.manager.display_view(undefined, view);
     return view;
 }
@@ -32,4 +32,4 @@ async function make_cell(options, skip_add) {
     if(!skip_add)
         this.sheet.set('cells', [...cells, cell])
     return cell
-}
+}

setup.py

@@ -139,7 +139,7 @@ def run(self):
         ('etc/jupyter/nbconfig/notebook.d', ['ipysheet.json'])
     ],
     'install_requires': [
-        'ipywidgets>=7.4.2',
+        'ipywidgets>=7.0.0',
     ],
     'packages': find_packages(),
     'zip_safe': False,