Fix widget synchonization issue and CI build (#58)

* Fix widget synchonization issue * Fix build
jupyter-widgets-contrib · Mar 4, 2019 · 5db721c · 5db721c
1 parent 6b5ca42
commit 5db721c
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/js/package.json b/js/package.json
@@ -16,7 +16,7 @@
   ],
   "scripts": {
     "prepare": "npm run build",
-    "build": "tsc --project . || webpack --mode=development",
+    "build": "tsc --project . && webpack --mode=development",
     "watch": "npm-run-all -p watch:*",
     "watch:lib": "tsc -w --project .",
     "watch:nbextension": "webpack --watch --mode=development",

diff --git a/js/src/sheet.ts b/js/src/sheet.ts
@@ -308,7 +308,7 @@ let SheetView = widgets.DOMWidgetView.extend({
         for (let key in this.widget_views) {
             if(this.widget_views.hasOwnProperty(key)) {
                 // Ugly, this should be properly done
-                let [row, col] = String(key).split(',').map(parseInt);
+                let [row, col] = String(key).split(',').map(x => parseInt(x));
                 let widget_view = this.widget_views[key];
                 if(data[row][col] && data[row][col].value && data[row][col].value.cid == widget_view.model.cid) {
                     // good, the previous widget_view should be reused

diff --git a/js/tsconfig.json b/js/tsconfig.json
@@ -3,7 +3,6 @@
     "resolveJsonModule": true,
     "noImplicitAny": false,
     "lib": ["dom", "es5", "es2015.promise", "es2015.iterable"],
-    "noEmitOnError": false,
     "strictNullChecks": true,
     "module": "commonjs",
     "moduleResolution": "node",