Skip to content

Commit

Permalink
Merge pull request #39 from martinRenou/sourcemaps
Browse files Browse the repository at this point in the history
Add sourcemap files back
  • Loading branch information
SylvainCorlay committed Feb 19, 2019
2 parents e1d6e05 + 4d6edff commit 64e28e9
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 8 deletions.
2 changes: 1 addition & 1 deletion js/karma.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ module.exports = function (config) {
rules: webpackConfig[2].module.rules
},
// source mapping without inline does not seem to work
devtool: 'inline-source-map',
devtool: 'source-map',
mode: 'development',
resolve: {
extensions: ['.js'],
Expand Down
8 changes: 2 additions & 6 deletions js/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ module.exports = [
// extension.
//
entry: './lib/src/extension.js',
devtool: 'inline-source-map',
resolve: resolve,
module: {
rules: rules
Expand All @@ -42,7 +41,6 @@ module.exports = [
{
// same for renderer
entry: './lib/src/extension-renderer.js',
devtool: 'inline-source-map',
resolve: resolve,
output: {
filename: 'extension-renderer.js',
Expand All @@ -58,7 +56,7 @@ module.exports = [
// It must be an amd module
//
entry: './lib/src/index.js',
devtool: 'inline-source-map',
devtool: 'source-map',
resolve: resolve,
output: {
filename: 'index.js',
Expand All @@ -73,7 +71,7 @@ module.exports = [
{
// same for render
entry: './lib/src/renderer.js',
devtool: 'inline-source-map',
devtool: 'source-map',
resolve: resolve,
output: {
filename: 'renderer.js',
Expand Down Expand Up @@ -101,7 +99,6 @@ module.exports = [
// by the custom widget embedder.
//
entry: './lib/src/embed.js',
devtool: 'inline-source-map',
resolve: resolve,
output: {
filename: 'index.js',
Expand All @@ -117,7 +114,6 @@ module.exports = [
{
// same for renderer
entry: './lib/src/renderer.js',
devtool: 'inline-source-map',
resolve: resolve,
output: {
filename: 'renderer.js',
Expand Down
4 changes: 3 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,10 @@ def run(self):
'ipysheet/static/handsontable.js',
'ipysheet/static/extension.js',
'ipysheet/static/index.js',
'ipysheet/static/index.js.map',
'ipysheet/static/extension-renderer.js',
'ipysheet/static/renderer.js'
'ipysheet/static/renderer.js',
'ipysheet/static/renderer.js.map'
]),
('etc/jupyter/nbconfig/notebook.d' , ['ipysheet.json'])
],
Expand Down

0 comments on commit 64e28e9

Please sign in to comment.