Merge pull request #26 from martinRenou/allow_zero_in_cell

Allow zero value in cells
jupyter-widgets-contrib · Feb 13, 2019 · d1c64d3 · d1c64d3
2 parents 73a60af + 7023e91
commit d1c64d3
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/js/src/sheet.ts b/js/src/sheet.ts
@@ -110,8 +110,9 @@ let SheetModel = widgets.DOMWidgetModel.extend({
     },
     _cell_data_to_grid: function(cell, data) {
         let value = cell.get('value');
-        if(!value)
-            return
+        if((value === null) || (value === undefined)) {
+            return;
+        }
         for(let i = cell.get('row_start'); i <= cell.get('row_end'); i++) {
             for(let j = cell.get('column_start'); j <= cell.get('column_end'); j++) {
                 let value = cell.get('value');

diff --git a/js/src/test/sheet.ts b/js/src/test/sheet.ts
@@ -161,6 +161,11 @@ describe('sheet', function() {
         var data = this.sheet.get('data')
         expect(data[1][2].value, 'when cell.value is change').to.equal(999);
     })
+    it('numeric cell with value zero should indeed have value zero', async function() {
+        await make_cell.apply(this, [{value: 0.00, type:'numeric'}]);
+        var data = this.sheet.get('data');
+        expect(data[1][2].value, 'for initial value').to.equal(0);
+    })
     it('multiple cells added', async function() {
         var cell1 = await make_cell.apply(this, [{value: 777}, true])
         var cell2 = await make_cell.apply(this, [{row_start: 0, row_end:0, value: 555}, true])