Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken SVG #153

Merged
merged 1 commit into from
May 25, 2023
Merged

Fix broken SVG #153

merged 1 commit into from
May 25, 2023

Conversation

martinRenou
Copy link
Collaborator

No description provided.

@martinRenou martinRenou added the bug Something isn't working label May 25, 2023
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch martinRenou/jupytercad/fix_broken_svg

@martinRenou
Copy link
Collaborator Author

For some reason the SVG would not render anymore in the UI because of the missing newline at the end. It also would not render in the Github diff preview.

@martinRenou
Copy link
Collaborator Author

Even weirder is that the visual regression tests did not catch this. It did catch it in #150 though.

@martinRenou martinRenou merged commit 011d841 into jupytercad:main May 25, 2023
6 checks passed
@martinRenou martinRenou deleted the fix_broken_svg branch May 25, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trungleduc trungleduc Awaiting requested review from trungleduc

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@martinRenou