Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve lighting #158

Merged
merged 2 commits into from
May 29, 2023
Merged

Improve lighting #158

merged 2 commits into from
May 29, 2023

Conversation

trungleduc
Copy link
Member

Before

before

After

after

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch trungleduc/jupytercad/update-light

@trungleduc trungleduc added the enhancement New feature or request label May 26, 2023
@trungleduc
Copy link
Member Author

Hey please update snapshots

@trungleduc trungleduc closed this May 26, 2023
@trungleduc trungleduc reopened this May 26, 2023
martinRenou
martinRenou approved these changes May 29, 2023
View reviewed changes
Copy link
Collaborator

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

packages/jupytercad-extension/src/mainview.tsx

const light = new THREE.SpotLight(0xffffff, 0.2);
const light = new THREE.PointLight(0xffffff, 1);
light.castShadow = true;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should disable the shadowmap computing. We're not using it so we could save some perf here.

packages/jupytercad-extension/src/mainview.tsx

const light = new THREE.SpotLight(0xffffff, 0.2);
const light = new THREE.PointLight(0xffffff, 1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not know adding a point light to the camera would make the point light stick to the camera position! That's good to know!

@martinRenou martinRenou merged commit b48425b into jupytercad:main May 29, 2023
5 checks passed
@trungleduc trungleduc deleted the update-light branch May 7, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@trungleduc @martinRenou