Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup visibility checking #161

Merged
merged 3 commits into from
May 29, 2023
Merged

Fixup visibility checking #161

merged 3 commits into from
May 29, 2023

Conversation

martinRenou
Copy link
Collaborator

The logic should be:

  • Set visible to True by default
  • Check if object_data.visible exists, if it does, set visible to its value
  • Check if gui_data[object_data['name']].visibilty exists, if it does, set visible to its value

That way, the gui data has precedence over the object data if it exists

@martinRenou martinRenou added the bug Something isn't working label May 29, 2023
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch martinRenou/jupytercad/fixup_visibility

@martinRenou
Copy link
Collaborator Author

martinRenou commented May 29, 2023 •
edited

Will you please update snapshots again

@martinRenou martinRenou marked this pull request as draft May 29, 2023 14:37
@martinRenou martinRenou reopened this May 29, 2023
@martinRenou martinRenou marked this pull request as ready for review May 29, 2023 15:35
@martinRenou martinRenou merged commit b387d67 into jupytercad:main May 29, 2023
5 checks passed
@martinRenou martinRenou deleted the fixup_visibility branch May 29, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@martinRenou