Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python API #162

Merged
merged 9 commits into from
Jun 1, 2023
Merged

Python API #162

merged 9 commits into from
Jun 1, 2023

Conversation

martinRenou
Copy link
Collaborator

@martinRenou martinRenou commented May 29, 2023 •
edited

Implementing a simple Python API for shape creation and operators

Screenshot from 2023-05-29 16-15-50

TODO:

  • Visual regression tests
  • Implement all operators
  • Placement should be configurable
  • update_object implementation Let's do that later -> turn this into an issue

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch martinRenou/jupytercad/python_api

@martinRenou martinRenou added the enhancement New feature or request label May 29, 2023
@martinRenou martinRenou force-pushed the python_api branch 2 times, most recently from 090b610 to c270d89 Compare May 31, 2023 08:08
@martinRenou
Copy link
Collaborator Author

martinRenou commented May 31, 2023 •
edited

please update snapshots !!!!!!!!

@martinRenou martinRenou force-pushed the python_api branch 3 times, most recently from 12612fa to 8c152a8 Compare May 31, 2023 12:55
@martinRenou martinRenou reopened this May 31, 2023
@martinRenou martinRenou marked this pull request as ready for review May 31, 2023 13:55
trungleduc
trungleduc reviewed May 31, 2023
View reviewed changes
examples/test.jcad Outdated Show resolved Hide resolved
trungleduc
trungleduc reviewed May 31, 2023
View reviewed changes
jupytercad/notebook/cad_document.py Show resolved Hide resolved
jupytercad/notebook/cad_document.py Outdated Show resolved Hide resolved
jupytercad/notebook/cad_document.py Outdated Show resolved Hide resolved
jupytercad/notebook/cad_document.py Show resolved Hide resolved
@martinRenou martinRenou closed this Jun 1, 2023
@martinRenou martinRenou reopened this Jun 1, 2023
@trungleduc
Copy link
Member

The failed integration tests look legit

@martinRenou
Copy link
Collaborator Author

Yeah it seems to be since the rebase on master, we now have something printed about the FREECAD path in the Notebook output. We may not want this.

@trungleduc
Copy link
Member

trungleduc commented Jun 1, 2023 •
edited

Yeah it seems to be since the rebase on master, we now have something printed about the FREECAD path in the Notebook output. We may not want this.

ah ok, it's because we try to import freecad to see if it's available. Let's merge this PR and fix this issue later

@martinRenou
Copy link
Collaborator Author

Sounds good!

@martinRenou martinRenou merged commit 65c8ba9 into jupytercad:main Jun 1, 2023
4 of 5 checks passed
@martinRenou martinRenou deleted the python_api branch June 1, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trungleduc trungleduc trungleduc approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@martinRenou @trungleduc