Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shadow to annotation boxes #163

Merged
merged 1 commit into from
May 30, 2023
Merged

Add shadow to annotation boxes #163

merged 1 commit into from
May 30, 2023

Conversation

trungleduc
Copy link
Member

@trungleduc trungleduc commented May 30, 2023 •
edited

Closes #157

annotation

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch trungleduc/jupytercad/annotation-bg

@trungleduc trungleduc added the enhancement New feature or request label May 30, 2023
martinRenou
martinRenou requested changes May 30, 2023
View reviewed changes
Copy link
Collaborator

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

packages/jupytercad-extension/style/base.css Outdated Show resolved Hide resolved
@trungleduc trungleduc force-pushed the annotation-bg branch 2 times, most recently from d090873 to 6dedf61 Compare May 30, 2023 12:13
martinRenou
martinRenou approved these changes May 30, 2023
View reviewed changes
Copy link
Collaborator

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou merged commit 7829c62 into jupytercad:main May 30, 2023
6 checks passed
@trungleduc trungleduc deleted the annotation-bg branch May 7, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Annotation has the same background as the 3D viewer
2 participants
@trungleduc @martinRenou