Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dragging not possible anymore on non-touch devices #10

Closed
tkempken opened this issue Sep 6, 2022 · 0 comments · Fixed by #13 · May be fixed by #11
Closed

Dragging not possible anymore on non-touch devices #10

tkempken opened this issue Sep 6, 2022 · 0 comments · Fixed by #13 · May be fixed by #11

Comments

@tkempken
Copy link

tkempken commented Sep 6, 2022 •
edited

Dragging of split slider is not possible (anymore) due to an incorrect assumption of the L.Browser module.

on(range, L.Browser.touch ? 'touchstart' : 'mousedown', cancelMapDrag, this)

on(range, L.Browser.touch ? 'touchend' : 'mouseup', uncancelMapDrag, this)

Tested with Google Chrome 105.0.5195.102 and version earlier.
Android/iOS is still working, only desktop browsers are affected.

Background;:

L.Browser.touch stays true even if you are using a non-touch device. It would be better to rely on global window variable like other leaflet plugins.
tkempken added a commit to tkempken/leaflet-splitmap that referenced this issue Sep 12, 2022
@tkempken
fix QuantStack#10
6991c99
@tkempken tkempken mentioned this issue Sep 12, 2022
Open
oxidase added a commit to oxidase/leaflet-splitmap that referenced this issue Sep 7, 2023
@oxidase
fix: fix clip issues QuantStack#10
a5540e6
@oxidase oxidase mentioned this issue Sep 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@tkempken