Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please consider using pkg-config for cryptopp #113

Closed
yurivict opened this issue Dec 22, 2018 · 3 comments
Closed

Please consider using pkg-config for cryptopp #113

yurivict opened this issue Dec 22, 2018 · 3 comments

Comments

@yurivict
Copy link

https://github.com/QuantStack/xeus/blob/master/CMakeLists.txt#L58

cppcrypto dropped cmake support. There is crypto-cmake project that breaks: noloader/cryptopp-cmake#45

If the project doesn't officially support cmake, you probably shouldn't insist on expecting it.

In the FreeBSD port, I have this patch:

+FIND_PACKAGE(PkgConfig)
 find_package(nlohmann_json 3.2.0 REQUIRED)
 find_package(xtl 0.5 REQUIRED)
 find_package(cppzmq 4.3.0 REQUIRED)
-find_package(cryptopp REQUIRED)
+pkg_check_modules(cryptopp libcryptopp REQUIRED)

that works fine with cryptocpp project as it is distributed.

@SylvainCorlay
Copy link
Member

Yeah, we dropped cmake for zeromq because is was not the standard way of building zeromq.

What I think we should do is support both in the same way cppzmq supports both cmake and pkg-config for zeromq.

@SylvainCorlay
Copy link
Member

So can find what we did for zeromq here:

https://github.com/QuantStack/xeus/blob/master/CMakeLists.txt#L60-L67

@SylvainCorlay SylvainCorlay changed the title Please consider using pkg-config for cpprcypto Please consider using pkg-config for cryptopp Dec 22, 2018
@noloader
Copy link

noloader commented Dec 22, 2018

My apologies for jumping in on other's bug... If you guys need immediate help them ping me at noloader, gmail account. Projects and distros get special privileges.

You are still welcomed to file bug reports if you like. I use them for change control and documentation so if you don't then I may file one on your behalf. I sometimes skip on the trivial fixes, but I file reports for the non-trivial stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants