[xnpy] Add signed char
to deserialization format
#1017
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
signed int
andint
are the same datatype, but upon doingstd::is_same<char, signed_char>::value
, we can see that it is not. Therefore, we need to addsigned char
as a member intoxnpy
's deserialization step.Why do we need
signed char
? Becausestd::int8_t
aliases tosigned char
and people may useint8_t
as a data type in a xtensor array in the future.