Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add z5 to related projects #1620

Merged
merged 1 commit into from May 22, 2019
Merged

Conversation

constantinpape
Copy link
Contributor

See discussion in #1612.

@wolfv
Copy link
Member

wolfv commented May 22, 2019

Let me know when ready!

By the way, do you think it would make sense to run your tests as part of our new CI infrastructure that rebuilds all projects dependent on xtensor whenever master changes?

http://195.201.91.244:8080/teams/main/pipelines/xstack

@constantinpape
Copy link
Contributor Author

Let me know when ready!

This is good to go from my side, but let me know if you think there is some need for clarification.
Unfortunately I don't have a logo yet; I was planning to do one for a while, but didn't have time to design one yet. I will make another PR once I had time to do this.

By the way, do you think it would make sense to run your tests as part of our new CI infrastructure that rebuilds all projects dependent on xtensor whenever master changes?

Yes, this would be really cool. What's the procedure for setting this up?

@wolfv wolfv merged commit d867ff2 into xtensor-stack:master May 22, 2019
@wolfv
Copy link
Member

wolfv commented May 22, 2019

merged, only docs.

@wolfv
Copy link
Member

wolfv commented May 22, 2019

The source for the build tasks lives in a secret repository located here: https://github.com/xtensorgistbucket/droneme/ (don't mind the name ...)

The tasks are located under /tasks/. You can select a base docker image in the test.yml file, and the inputs you rely on. Then just write a script.sh that builds z5, that's it!
I think you can extract a lot of the steps from what's already there. Would be cool if you do it! I am happy to help and test!

@constantinpape
Copy link
Contributor Author

constantinpape commented May 22, 2019

The tasks are located under /tasks/. You can select a base docker image in the test.yml file, and the inputs you rely on. Then just write a script.sh that builds z5, that's it!

I had a quick look and this looks pretty straightforward indeed. I can probably more or less reuse my travis set-up.

I am on a conference next week and probably don't have time to look into this beforehand, but I will try to add z5 afterwards.

I opened an issue in z5 to keep track of this:
constantinpape/z5#112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants