Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we return MatrixBase more often? #104

Closed
MarcAntoineSchmidtQC opened this issue Aug 3, 2021 · 2 comments
Closed

Should we return MatrixBase more often? #104

MarcAntoineSchmidtQC opened this issue Aug 3, 2021 · 2 comments
Milestone

Comments

@MarcAntoineSchmidtQC
Copy link
Member

There are operations currently that return non-MatrixBase results. Is there a good reason to do this if the result does not become a scalar?

For instance, CategoricalMatrix * DenseMatrix -> scipy.sparse.csr_matrix instead of a SparseMatrix. Another one is indexing on SparseMatrix, which return a np.matrix type.

@tbenthompson
Copy link
Collaborator

For the most part, I think we should treat these as bugs unless there's something that I'm missing.

But, I guess I have a general concern about the scale of the task set forth by quantcore.matrix. Is this only the tip of the iceberg in terms of objects that need to be converted back to MatrixBase objects? Or are there just a few operations to fix and we'll be done? Any guesses here?

@MatthiasSchmidtblaicherQC
Copy link
Contributor

Addressed by #286.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants