Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tags should use a fast priority queue that resolves ties in FIFO order #74

Closed
Krastanov opened this issue Nov 20, 2023 · 1 comment
Closed

Tags should use a fast priority queue that resolves ties in FIFO order #74

Krastanov opened this issue Nov 20, 2023 · 1 comment
Labels
enhancement New feature or request performance

Comments

@Krastanov
Copy link
Member

DataStructures.PriorityQueue does not properly resolve ties (see JuliaCollections/DataStructures.jl#498 ), hence we are using a slow simple Vector implementation currently (since #69 ). Implementing (and benchmarking) a potential new FIFO-tie-breaking priority queue might greatly increase tagging performance.
@Krastanov Krastanov added enhancement New feature or request performance labels Nov 20, 2023
@Krastanov
Copy link
Member Author

related to #80

@Abhishek-1Bhatt Abhishek-1Bhatt mentioned this issue May 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Krastanov