Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Qua] Serializer misconverts "null" string to null value #3900

Closed
AiAe opened this issue Sep 5, 2023 · 1 comment
Closed

[Qua] Serializer misconverts "null" string to null value #3900

AiAe opened this issue Sep 5, 2023 · 1 comment
Labels
Bug Editor Requires Quaver.API

Comments

@AiAe
Copy link
Member

AiAe commented Sep 5, 2023

Describe the bug

If we set DifficultyName: NULL as our difficulty name, Quaver will fail to parse it and will result in black window.

Looks like that has been fixed in newer versions of YamlDotNet aaubry/YamlDotNet#699

To Reproduce

  1. Change name from .qp.zip to .qp
    Frums_-HALL-_21928 - Copy.qp.zip
  2. Import the file
  3. Open editor

Expected behavior

No response

Log Files

runtime.log

Screenshots

No response
@Swan
Copy link
Member

Swan commented Sep 11, 2023

Fixed in this commit. It's not that it fails to parse. It's that SpriteTextPlus couldn't handle when the text is null, so now it defaults to an empty string.

@Swan Swan closed this as completed Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Editor Requires Quaver.API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AiAe @Swan