-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot change border size in qubes-desktop-linux-i3 #6589
Cannot change border size in qubes-desktop-linux-i3 #6589
Comments
I'd be happy to supply a PR, but I'm not sure where to begin to set up a build environment for this. Let me know if you need the help and I can try reading up on it. |
I'm sure that would be appreciated, thank you! The dev documentation might have what you need to set up a build environment: https://www.qubes-os.org/doc/#developer-documentation |
This issue is being closed because:
If anyone believes that this issue should be reopened and reassigned to an active milestone, please leave a brief comment. |
Affects 4.1 Sorry, I never got around to figuring out how to set up a build environment for dom0, so I could never test the code and I sort of let this ticket stagnate. The upstream code is still missing from the Qubes-patched version, so it should be reincorporated following my previous sleuth work above. Though it might need to be massaged a bit in case it's bitrotted in the time since I posted. |
Instead of making the border width a hardcoded constant, specify a minimum value (3) but allow users to increase it. Fixes: QubesOS/qubes-issues#6589
Affects |
Instead of making the border width a hardcoded constant, specify a minimum value (3) but allow users to increase it. Fixes: QubesOS/qubes-issues#6589
Qubes OS version
R4.0
Affected component(s) or functionality
qubes-desktop-linux-i3
version1000:4.16-9.fc25
.Brief summary
It seems the
default_border
setting and theborder
command are ignored.How Reproducible
Every time
To Reproduce
Steps to reproduce the behavior:
~/.config/i3/config
in dom0:Expected behavior
The terminal window should have a border size of 10 pixels.
The Firefox window should have a border size of 30 pixels.
Actual behavior
Border size is unaffected in both cases.
Additional context
I think this is caused by the following line in the Qubes patch for i3:
https://github.com/QubesOS/qubes-desktop-linux-i3/blob/93b8b1ba9d41f56c85bea4752a7270fe1468fb36/0001-Show-qubes-domain-in-configurable-colored-borders.patch#L180
Following the Git blame, it seems that this was first introduced when bumping the upstream version to
4.16
. Comparing it with the patch for version4.15
and using the then-upstream repo as reference, it looks like the previous behavior was to only override the width when the upstream one set it to a constant value, and using the user-supplied value in all other cases. The bump to4.16
changed this to be overridden in all instances, presumably by mistake.In order to follow a similar behavior as in previous versions, the patch should instead produce code akin to:
(NOTE: The above code has not been tested.)
Solutions you've tried
I configured both with really exaggerated border sizes (as above) to make sure I definitely would notice if it worked.
I have confirmed that the Firefox window is matched correctly by modifying other settings on it with
for_window
, it's just theborder
command that is broken.I have successfully used these settings in i3 on non-Qubes machines previously.
Relevant documentation you've consulted
https://i3wm.org/docs/userguide.html#_default_border_style_for_new_windows
https://i3wm.org/docs/userguide.html#_changing_border_style
https://i3wm.org/docs/userguide.html#for_window
Related, non-duplicate issues
None
The text was updated successfully, but these errors were encountered: