Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom label colors in GUI Updater #9236

Open
alimirjamali opened this issue May 16, 2024 · 0 comments · May be fixed by QubesOS/qubes-desktop-linux-manager#197
Open

Allow custom label colors in GUI Updater #9236

alimirjamali opened this issue May 16, 2024 · 0 comments · May be fixed by QubesOS/qubes-desktop-linux-manager#197
Assignees
@alimirjamali
Labels
C: manager/widget P: minor Priority: minor. The lowest priority, below "default." pr submitted A pull request has been submitted for this issue. T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality.

Comments

@alimirjamali
Copy link

alimirjamali commented May 16, 2024 •
edited
Loading

How to file a helpful issue

The problem you're addressing (if any)

Qube name label colors in Qubes OS Updater intro page is currently hard-coded in CSS and Python. If users create their custom labels via community tools or by invoking admin.label.Create API call and provide their XDG Icons, it will not show properly in GUI updater (all other GUI widgets are fine). The problem is only with light themes.

updater-before

The solution you'd like

A simple easy fix would be setting black label text for light themes and white label text for dark themes only for user defined custom labels. This is a nice compromise. It will look like this:

updater-after

The value to a user, and who that user might be

Users who are using custom scripts to create their own custom label will be able to use the GUI updater with the light themes. This is just two lines of CSS (I will submit patch shortly)

Completion criteria checklist

(This section is for developer use only. Please do not modify it.)
@alimirjamali alimirjamali added P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality. labels May 16, 2024
@alimirjamali alimirjamali linked a pull request May 16, 2024 that will close this issue
Open
@andrewdavidwong andrewdavidwong added C: manager/widget P: minor Priority: minor. The lowest priority, below "default." pr submitted A pull request has been submitted for this issue. and removed P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. labels May 17, 2024
alimirjamali added a commit to alimirjamali/qubes-desktop-linux-manager that referenced this issue Jun 24, 2024
@alimirjamali
Fixing GUI Updater Label colors for custom labels
5975ea5 
Fixes: QubesOS/qubes-issues#9236
alimirjamali added a commit to alimirjamali/qubes-desktop-linux-manager that referenced this issue Jun 30, 2024
@alimirjamali
Fixing CSS for Updater GUI VM Name Labels
1fcfe2a 
Fixes QubesOS/qubes-issues#9236
alimirjamali added a commit to alimirjamali/qubes-desktop-linux-manager that referenced this issue Jul 1, 2024
@alimirjamali
Fixing CSS for Updater GUI VM Name Labels
31c3a76 
Fixes QubesOS/qubes-issues#9236
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alimirjamali alimirjamali

Labels
C: manager/widget P: minor Priority: minor. The lowest priority, below "default." pr submitted A pull request has been submitted for this issue. T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing CSS for Updater VM name Labels alimirjamali/qubes-desktop-linux-manager
2 participants
@alimirjamali @andrewdavidwong