Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help text in policy editor is wrapped to too wide size #9060

Closed
marmarek opened this issue Mar 27, 2024 · 1 comment · Fixed by QubesOS/qubes-desktop-linux-manager#204
Closed
Assignees
Labels
affects-4.2 This issue affects Qubes OS 4.2. C: manager/widget diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.

Comments

@marmarek
Copy link
Member

How to file a helpful issue

Qubes OS release

R4.2

Brief summary

When opening policy editor in a smaller window, the right side of help text is cut

Steps to reproduce

  1. Open policy editor
  2. Make the window smaller

Expected behavior

Either help text wraps to a smaller width, or help text area remains at the size of minimal text wrap width

Actual behavior

Help text wraps until some minimal width is reached and then right side of it is cut.

policy-editor-crop

@marmarek marmarek added T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. C: manager/widget P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. affects-4.2 This issue affects Qubes OS 4.2. labels Mar 27, 2024
@andrewdavidwong andrewdavidwong added the needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. label Mar 28, 2024
@alimirjamali
Copy link

alimirjamali commented Jun 27, 2024

Ok. I had time to take a look at the Glade file and the code.

The current width-request for source_window is set to 1000 pixels. And 500 pixels for help_window. The total is 1500 pixels (excluding window border) which is above 1366 pixel width of common displays and above 1024 pixel of OpenQA test. Reducing the former to 800 pixel and the latter to 450 pixel makes it look good on 1366 pixel width displays. But most probably not on Open QA. We simply have too much data to display.

The current height-request for main_window is set at 800 pixels. This is why the "Quit, Save Changes" and "Save and Exit" buttons do not show on 1366x768 displays as well as Open QA 1024x768 virtual display test. I suggest reducing it to 700 pixel as it looks good. This would also enable maximizing on the mentioned displays.

My other findings

  • Adding 10 pixel border-width to help_viewport makes it look very nice.
  • Maximizing on launch might be a good idea. As the program packs a lot of information and launching it maximized makes it comfortable. User could still un-maximize or resize the window.

PR Submitted. Please let me know which points could be agreed, rejected or amended. Here is the screen snapshot of program with the applied changes (so far):

policy_editor

@andrewdavidwong andrewdavidwong added diagnosed Technical diagnosis has been performed (see issue comments). pr submitted A pull request has been submitted for this issue. and removed needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. labels Jul 18, 2024
marmarek pushed a commit to QubesOS/qubes-desktop-linux-manager that referenced this issue Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-4.2 This issue affects Qubes OS 4.2. C: manager/widget diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants