qubes-dom0-update throws non-zero error code when package already installed

[r-cheologist]

Qubes OS version:

4.0-rc2

Affected TemplateVMs:

dom0

---

Steps to reproduce the behavior:

PROMPT> qubes-dom0-update qubes-template-fedora-26-minimal
... Complete!

PROMPT> qubes-dom0-update qubes-template-fedora-26-minimal
.... No match for argument qubes-template-fedora-26 minimal

Expected behavior:

Along the lines of plain qubes-dom0-update - it states No new updates available and gracefully exits with error code 0 when nothing is to be done. Maybe qubes-dom0-update <PACKAGE> should state something like Package <PACKAGE> already installed, but it should DEFINITELY NOT throw an error code 1.

Actual behavior:

If the package is already installed qubes-dom0-update <PACKAGE> states the misleading/false No Match for argument <PACKAGE> and returns error code 1.

General notes:

---

Related issues:

[tasket]

Hmmm, I tried this with qubes-template-debian-9 (already installed) and it says "No packages downloaded... Nothing to do" and 0 return code. Can't reproduce on rc2.

[andrewdavidwong]

"No match for argument" sounds like there was a typo in the command.

It looks like that might be happening here:

PROMPT> qubes-dom0-update qubes-template-fedora-26-minimal
.... No match for argument qubes-template-fedora-26 minimal
                                                   ^ Missing hyphen?

[ghost]

I confirm this bug, today on Qubes R4.0 up to date(non-testing) where I already have templates for 25,26 and 28 installed, but not 27:

[ctor@dom0 ~]$ sudo qubes-dom0-update qubes-template-fedora-25
Using sys-firewall as UpdateVM to download updates for Dom0; this may take some time...
Last metadata expiration check: 1:26:38 ago on Fri Aug 24 20:21:16 2018.
No match for argument: qubes-template-fedora-25
Error: Unable to find a match
[ctor@dom0 ~]$ sudo qubes-dom0-update qubes-template-fedora-26
Using sys-firewall as UpdateVM to download updates for Dom0; this may take some time...
Last metadata expiration check: 1:26:47 ago on Fri Aug 24 20:21:16 2018.
No match for argument: qubes-template-fedora-26
Error: Unable to find a match
[ctor@dom0 ~]$ sudo qubes-dom0-update qubes-template-fedora-27
Using sys-firewall as UpdateVM to download updates for Dom0; this may take some time...
Last metadata expiration check: 1:27:07 ago on Fri Aug 24 20:21:16 2018.
Dependencies resolved.
================================================================================
 Package                  Arch   Version              Repository           Size
================================================================================
Installing:
 qubes-template-fedora-27 noarch 4.0.0-201805211758   qubes-templates-itl 1.3 G

Transaction Summary
================================================================================
Install  1 Package

Total size: 1.3 G
Installed size: 1.3 G
DNF will only download packages for the transaction.
Downloading Packages:
[SKIPPED] qubes-template-fedora-27-4.0.0-201805211758.noarch.rpm: Already downloaded
Complete!
The downloaded packages were saved in cache until the next successful transaction.
You can remove cached packages by executing 'dnf clean packages'.
qfile-agent: Fatal error: File copy: Disk quota exceeded; Last file: qubes-template-fedora-27-4.0.0-201805211758.noarch.rpm (error type: Disk quota exceeded)
'/usr/lib/qubes/qrexec-client-vm dom0 qubes.ReceiveUpdates /usr/lib/qubes/qfile-agent /var/lib/qubes/dom0-updates/packages/*.rpm' failed with exit code 1!
[ctor@dom0 ~]$ sudo qubes-dom0-update qubes-template-fedora-28
Using sys-firewall as UpdateVM to download updates for Dom0; this may take some time...
Last metadata expiration check: 1:28:05 ago on Fri Aug 24 20:21:16 2018.
No match for argument: qubes-template-fedora-28
Error: Unable to find a match

EDIT: if anyone stumbles upon this by searching for disk quota exceeded - looks like sys-firewall's TemplateVM (eg. fedora-28) 's System storage max. size (not Private storage) could be increased (after which you still need to restart sys-firewall if not more: like change its template value to something else (like fedora-26), apply/ok, then change it back(to fedora-28), to sense the storage value change - or maybe this is just a Qube Manager visual thing?), or just simply restart the sys-firewall qube, which should free the space from /. More (outdated?) info / source: here and here

[github-actions]

This issue is being closed because:

• This issue is on the "Release 4.0 updates" milestone.
• Qubes OS 4.0 reached EOL (end-of-life) over one year ago.
• There has not been any activity on this issue in over one year.

If anyone believes that this issue should be reopened and reassigned to an active milestone, please leave a brief comment.
(For example, if a bug still affects Qubes OS 4.1, then the comment "Affects 4.1" will suffice.)