Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canceling backup restore displays confirmation message, but restore is never actually cancelled #5304

Closed
heinrich-ulbricht opened this issue Sep 9, 2019 · 1 comment
Labels
C: core eol-4.0 Closed since Qubes 4.0 has been EOL for over one year P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.

Comments

@heinrich-ulbricht
Copy link

The problem you're addressing (if any)
Currently there are multiple issues regarding restoring large backups (in my case ~650 GB), e.g. #4791 and #3230. While trying to work around those I noticed another issue: it is not possible to cancel a running restore operation via the UI.

Choosing to cancel the restore operation outputs a red message that the operation is going to be canceled - but it never is. Looking at the task manager I see that the process tar -xiv [...] (-> restore.py) continues to run, which is responsible for extracting chunk files to my temporary directory. Apparently this process continues to run until all files are extracted - which in my case are ~6000. This leads to the situation described in #4791: the temp dir fills up, then the restore operation fails.

Describe the solution you'd like
I'd like the restore operation to stop immediately after choosing the cancel button. No need to continue extracting files.

Where is the value to a user, and who might that user be?
The value is a good user experience for every user restoring from larger backups.

Describe alternatives you've considered
Well. I used the task manager to kill some of the tar processes which makes the restore fail and thus end.

Additional context
This issue might be related to the "tar method" only. This method is used when restoring from a backup accessible to dom0. (So the backup is NOT restored from an AppVM.)

Related, non-duplicate issues

#4791
#3230

@heinrich-ulbricht heinrich-ulbricht added P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality. labels Sep 9, 2019
@heinrich-ulbricht heinrich-ulbricht changed the title Cannot Cancel Running Restore Operation (dom0 Restore, Qubes 4) Cannot Cancel Running Restore Operation (Restore from dom0, Qubes 4) Sep 9, 2019
@andrewdavidwong andrewdavidwong added C: core T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. and removed T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality. labels Sep 10, 2019
@andrewdavidwong andrewdavidwong added this to the Release 4.0 updates milestone Sep 10, 2019
@andrewdavidwong andrewdavidwong changed the title Cannot Cancel Running Restore Operation (Restore from dom0, Qubes 4) Canceling backup restore displays confirmation message, but restore is never actually cancelled Sep 10, 2019
@andrewdavidwong andrewdavidwong added the eol-4.0 Closed since Qubes 4.0 has been EOL for over one year label Aug 5, 2023
@github-actions
Copy link

github-actions bot commented Aug 5, 2023

This issue is being closed because:

If anyone believes that this issue should be reopened and reassigned to an active milestone, please leave a brief comment.
(For example, if a bug still affects Qubes OS 4.1, then the comment "Affects 4.1" will suffice.)

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: core eol-4.0 Closed since Qubes 4.0 has been EOL for over one year P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
None yet
Development

No branches or pull requests

2 participants