Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qvm-start-daemon - audiovm - keyboard layout #8109

Open
neowutran opened this issue Mar 21, 2023 · 0 comments · May be fixed by QubesOS/qubes-core-admin-client#237
Open

qvm-start-daemon - audiovm - keyboard layout #8109

neowutran opened this issue Mar 21, 2023 · 0 comments · May be fixed by QubesOS/qubes-core-admin-client#237
Labels
C: audio C: core P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality.

Comments

@neowutran
Copy link

How to file a helpful issue

The problem you're addressing (if any)

When using a audiovm, the system will complain that the audiovm is not allowed to override the keyboard layout.
Modifying the keyboard layout is normally only related to guivm, not audiovm.

The solution you'd like

I believe the issue is here:

https://github.com/QubesOS/qubes-core-admin-client/blob/main/qubesadmin/tools/qvm_start_daemon.py#L800
https://github.com/QubesOS/qubes-core-admin-client/blob/main/qubesadmin/tools/qvm_start_daemon.py#L792

The same actions are executed for both guivm and audiovm.
This is not a behavior wanted for the audiovm.
Maybe could add a check like that https://github.com/QubesOS/qubes-core-admin-client/blob/main/qubesadmin/tools/qvm_start_daemon.py#L741 to only execute thoses actions if the VM ask for guivm

The value to a user, and who that user might be

No useless warning, so not thinking that something don't work
@neowutran neowutran added P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality. labels Mar 21, 2023
@andrewdavidwong andrewdavidwong added this to the Release TBD milestone Mar 21, 2023
@neowutran neowutran linked a pull request Mar 23, 2023 that will close this issue
Open
@neowutran neowutran mentioned this issue Apr 18, 2023
Open
@andrewdavidwong andrewdavidwong removed this from the Release TBD milestone Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: audio C: core P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality.
Projects
None yet
Milestone
No milestone
2 participants
@neowutran @andrewdavidwong