Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot Stop sounds created on client with SoundUtils #254

Open
AverageLuaScripter opened this issue Mar 15, 2022 · 1 comment
Open

Cannot Stop sounds created on client with SoundUtils #254

AverageLuaScripter opened this issue Mar 15, 2022 · 1 comment
Labels

Comments

@AverageLuaScripter
Copy link

You cannot stop sounds created on the client with SoundUtils. This is as it uses DataModel:GetService("SoundService"):PlayLocalSound to play sounds locally. If the end user were to destroy the sound while it was still playing, it'd still play and this is especially annoying for use-cases such as doors or tools.

Another pet-peeve is that task.delay continues to run even if the sound is destroyed. Check if the sound is destroyed so you're not calling a nil value!

@Quenty
Copy link
Owner

Quenty commented Mar 27, 2022

See #256 for details on a fix for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants