Deserialize crashes on empty sections

[prydin]

With Minecraft 1.14, there are sometimes empty sections in the chunks. They look something like this:

Not sure why they appear, but they should be handled gracefully.

The code in Chunk.deserialize() tries to create a new Section here:

NBT/src/main/java/net/querz/nbt/mca/Chunk.java

Line 76 in 8cedf1e

this.sections[section.getByte("Y")] = new Section(section);

...but fails on a NullPointerException in the Section constructor since there's no Palette member here:

NBT/src/main/java/net/querz/nbt/mca/Section.java

Line 21 in 8cedf1e

palette = sectionRoot.getListTag("Palette").asCompoundTagList();

[Querz]

Ah yes, I faced this problem already some time ago in the MCASelector but didn't think this would be a problem here.
I'll fix that this weekend.

[Querz]

I added an extra check for sections that have a Y index outside of 0-15 and a check for palette content. Empty sections like those added by Minecraft will be treated as non-existent.

The changes are currently available with the latest commit on the master branch, if everything works fine i'll make a release.

[prydin]

I uncovered another issue. Sometimes you have a valid index, but the section is still empty (or at least missing the Palette). Here's how I addressed that:

https://github.com/prydin/NBT/blob/18761711dc4b88ecb3a68dd8e53b746693ffbbb9/src/main/java/net/querz/nbt/mca/Chunk.java#L75

[Querz]

Yes, I also addressed this issue, see
https://github.com/Querz/NBT/blob/master/src/main/java/net/querz/nbt/mca/Section.java#L21
If a Section is missing the Palette, it will be "empty" and won't be added to the chunk:
https://github.com/Querz/NBT/blob/master/src/main/java/net/querz/nbt/mca/Chunk.java#L75