Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class Incremental for Node Classification EWC and MAS cannot be reproduced #19

Open
WMX567 opened this issue May 31, 2023 · 2 comments
Open

Comments

@WMX567
Copy link

WMX567 commented May 31, 2023

Hi,

I ran the codes on A40 GPU, using the supplementary materials' hyperparameters.
EWC on CoraFull with 4.4±0.6 is far from 15.02 provided in the paper.

Thanks!

@QueuQ
Copy link
Owner

QueuQ commented Jul 9, 2023

Hi,

I ran the codes on A40 GPU, using the supplementary materials' hyperparameters. EWC on CoraFull with 4.4±0.6 is far from 15.02 provided in the paper.

Thanks!

Hi,

I just run the experiments two times, and got the results AP: 16.03 AF: -80.11 ; AP: 17.28 AF: -78.92.

Please make sure that the memory strength is 100000 for ewc, backbone is GCN. The minibatch should be set as False, Using minibatch or not may cause difference in performance, which should have be explained in the paper or Appendix, Therefore, to fairly compare the methods, we adopt full batch training consistently for all methods on small NCGL datasets like CoraFull-CL. The ILmode shoud be set as classIL. Please also notice that --inter-task-edges should be False, this may also cause difference in the performance.

@SONGLEI-arch
Copy link

Hi,
I met the same problem. Could you please provide more detailed settings?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants